Conversation
zoharma
force-pushed
the
zma/add-consumer-smoke-test
branch
from
September 16, 2026 15:38
b04b8a4 to
3b3a92a
Compare
Source-only tests never touch dist/, so the utif bundling regression
only surfaced once a real consumer imported the published package.
`pnpm test:dist` (test/*.test.ts, needs `pnpm build` first) covers:
- `dist-entrypoints`: every dist/*.{esm,cjs}.js entry point loads without throwing
- `no-unexpected-bundling`: utif still shows up as an external import, not inlined
- `dist-size`: total dist/*.js size hasn't grown >25% past a committed baseline
`pnpm test:consumer-smoke` (scripts/consumer-smoke-test.sh) packs the
built package into a tarball and installs it into two throwaway
fixtures, importing every entry point like a real consumer would:
- `e2e/consumer-smoke`: floating Vitest, general build health
- `e2e/consumer-smoke-legacy-vitest`: pinned to vitest 4.0.18/vite 7.3.5,
the exact versions that hit the 0.7.1 crash - the underlying Vite bug is
already fixed in newer versions, so this is the only fixture that
actually reproduces it and guards against a regression
Both scripts run in CI after `pnpm build`. e2e/ fixtures are excluded
from ESLint's typed linting and from the default `pnpm test` run,
since they're isolated projects with their own dependencies.
zoharma
force-pushed
the
zma/add-consumer-smoke-test
branch
from
September 16, 2026 20:40
192f20c to
cf56eaa
Compare
Contributor
Author
|
@VictoriaBeilsten-Edmands @douglaswinter @akademy take a look at this. A few tests added. Still a draft. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Source-only tests never touch dist/, so the utif bundling regression only surfaced once a real consumer imported the published package.
pnpm test:dist(test/*.test.ts, needspnpm buildfirst) covers:dist-entrypoints: every dist/*.{esm,cjs}.js entry point loads without throwingno-unexpected-bundling: utif still shows up as an external import, not inlineddist-size: total dist/*.js size hasn't grown >25% past a committed baselinepnpm test:consumer-smoke(scripts/consumer-smoke-test.sh) packs the built package into a tarball and installs it into two throwaway fixtures, importing every entry point like a real consumer would:e2e/consumer-smoke: floating Vitest, general build healthe2e/consumer-smoke-legacy-vitest: pinned to vitest 4.0.18/vite 7.3.5, the exact versions that hit the 0.7.1 crash - the underlying Vite bug is already fixed in newer versions, so this is the only fixture that actually reproduces it and guards against a regressionBoth scripts run in CI after
pnpm build. e2e/ fixtures are excluded from ESLint's typed linting and from the defaultpnpm testrun, since they're isolated projects with their own dependencies.