Skip to content

Include lamella number as part of site name in FIB workflow - #891

Open
tieneupin wants to merge 5 commits into
mainfrom
include-lamella-number
Open

tieneupin wants to merge 5 commits into
mainfrom
include-lamella-number

Conversation

@tieneupin

@tieneupin tieneupin commented Sep 16, 2026

Copy link
Copy Markdown
Contributor

Minor bug fixes to the existing FIB workflow.

When generating site names for the lamella evaluation images, we forgot to take into account the site number as well. This meant that the lamella images from the different sites shared the same site name, and would overwrite one another.

This PR fixes that by introducing logic in the metadata extraction function to append the site number to the site name if it can find it from the file path (which will be the case for lamella evaluation images, as they are nested under "Lamella (N)" or "Site #N").

Additionally, the site name naming format was changed. Previously, the layers were separated by '--', but that separator is one that users have been shown to use, and thus is insufficiently robust. We have swapped to using '/' instead (e.g. "cm12345-6/grid_1/lamella_11").

@codecov

codecov Bot commented Sep 16, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 55.03%. Comparing base (afc8fe9) to head (37ebde5).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #891      +/-   ##
==========================================
+ Coverage   54.95%   55.03%   +0.07%     
==========================================
  Files         103      103              
  Lines       11505    11515      +10     
  Branches     1526     1527       +1     
==========================================
+ Hits         6323     6337      +14     
+ Misses       4841     4836       -5     
- Partials      341      342       +1     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tieneupin
tieneupin marked this pull request as ready for review September 17, 2026 08:52
@tieneupin tieneupin self-assigned this Sep 17, 2026
@tieneupin tieneupin added bug Something isn't working server Relates to the server component fib Part of the FIB pipeline extension labels Sep 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working fib Part of the FIB pipeline extension server Relates to the server component

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant