Conversation
…ydantic model; updated site name generation logic so that it uses '/' instead of '--' as the section separators
…tes the 'lamella_number' field
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #891 +/- ##
==========================================
+ Coverage 54.95% 55.03% +0.07%
==========================================
Files 103 103
Lines 11505 11515 +10
Branches 1526 1527 +1
==========================================
+ Hits 6323 6337 +14
+ Misses 4841 4836 -5
- Partials 341 342 +1 🚀 New features to boost your workflow:
|
tieneupin
marked this pull request as ready for review
September 17, 2026 08:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Minor bug fixes to the existing FIB workflow.
When generating site names for the lamella evaluation images, we forgot to take into account the site number as well. This meant that the lamella images from the different sites shared the same site name, and would overwrite one another.
This PR fixes that by introducing logic in the metadata extraction function to append the site number to the site name if it can find it from the file path (which will be the case for lamella evaluation images, as they are nested under "Lamella (N)" or "Site #N").
Additionally, the site name naming format was changed. Previously, the layers were separated by '--', but that separator is one that users have been shown to use, and thus is insufficiently robust. We have swapped to using '/' instead (e.g. "cm12345-6/grid_1/lamella_11").