refactor: make client almost client again - #1666
Open
ZohebShaikh wants to merge 1 commit into
Open
ZohebShaikh wants to merge 1 commit into
ZohebShaikh wants to merge 1 commit into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1666 +/- ##
==========================================
- Coverage 96.34% 96.30% -0.05%
==========================================
Files 46 48 +2
Lines 3665 3676 +11
==========================================
+ Hits 3531 3540 +9
- Misses 134 136 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
ZohebShaikh
force-pushed
the
fix-dependencies
branch
from
September 10, 2026 17:47
62fc048 to
3f9a08d
Compare
tpoliaw
reviewed
Sep 14, 2026
|
|
||
| if (nt_conf := configuration.numtracker) is not None: | ||
| if configuration.env.metadata is not None: | ||
| from blueapi.service.numtracker import NumtrackerClient |
Contributor
There was a problem hiding this comment.
If we need to import it anyway, is there any real benefit to wrapping the initial import in the TYPE_CHECKING check?
I see the circular import error when importing the client eagerly. Were there other issues with numtracker being in the utils package instead of service? Lazy imports to avoid circular references feels like we're working around doing something wrong.
| "click>=8.2.0", | ||
| "fastapi>=0.112.0", | ||
| "uvicorn>=0.52.1", | ||
| "click>=8.2.0", # need for blueapi serve and blueapi setup-scratch |
Contributor
There was a problem hiding this comment.
click is needed for the whole CLI isn't it?
Suggested change
| "click>=8.2.0", # need for blueapi serve and blueapi setup-scratch | |
| "click>=8.2.0", |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I would like to go further in the split by doing the following but would like feedback on this before
bluesky, ophyd-async,event-model,opentelemetry-distro,observability-utilsto server onlyRelated to but does not solves #1414