Skip to content

ci: check that the committed bundle is up to date on release PRs #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
satsukies merged 3 commits into from
Oct 7, 2026
Merged

ci: check that the committed bundle is up to date on release PRs #85

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3b886ed
ci: check that the committed bundle is up to date on release PRs
satsukies Oct 7, 2026
819ea7c
ci: print manual recovery steps when the release bundle is stale
satsukies Oct 7, 2026
ab54814
Merge branch 'main' into ci/release-bundle-freshness
satsukies Oct 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 30 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,36 @@ jobs:

- run: npm run bundle

# Release PRs only: the committed bundle is what plugin users run, so it
# must match a fresh build. Elsewhere it is expected to lag behind main
# between releases, because it is only regenerated on the release PR.
# release.yml regenerates it only when release-please updates the PR, so
# a bundle made stale by later non-release commits on main (e.g.
# dependency bumps) has to be regenerated by hand; the steps are printed
# below when the check fails.
- name: Check that the committed bundle is up to date
if: github.event_name == 'pull_request' && startsWith(github.head_ref, 'release-please--')
env:
BRANCH: ${{ github.head_ref }}
run: |
if ! git diff --exit-code --stat plugin/scripts/bundle.js; then
echo "The committed bundle differs from a fresh build of this PR merged with main."
echo "Regenerate it on the release PR branch:"
echo ""
echo " git fetch origin"
echo " git switch -C ${BRANCH} origin/${BRANCH}"
echo " git merge origin/main"
echo " npm ci"
echo " npm run bundle"
echo " git add plugin/scripts/bundle.js"
echo " git commit --no-verify -m \"chore: regenerate bundle.js for release\""
echo " git push origin ${BRANCH}"
echo ""
echo "--no-verify is needed because the pre-commit hook blocks bundle commits outside the release workflow."
echo "::error file=plugin/scripts/bundle.js::The committed bundle is stale. Regenerate it on the release PR branch; see the steps in this log."
exit 1
fi

# Run the bundle on the exact minimum Node allowed by package.json
# "engines". Copy plugin/ out of the checkout first, as the plugin cache
# does, so neither node_modules nor the root package.json is visible.
Expand Down
Loading