Reset implementation for v4 architecture - #398
Merged
Merged
Conversation
…pty (currently working on v4); updated security for supported versions
Signed-off-by: DefinetlyNotAI <Shahm_Najeeb@outlook.com>
Retire script-sidecar discovery, execution, packaging, and compatibility paths. Document the plugin-only extension contract, command flags, and error remediation. Signed-off-by: DefinetlyNotAI <Shahm_Najeeb@outlook.com>
Move contract and platform boundaries into the engine module package. Keep compatibility aliases for established collector imports while documenting canonical locations. Signed-off-by: DefinetlyNotAI <Shahm_Najeeb@outlook.com>
DefinetlyNotAI
added
the
type/Documentation
DefinetlyNotAI
added
request/Important
Contributor
|
Important Review skippedToo many files! This PR contains 221 files, which is 121 over the limit of 100. To get a review, reduce the PR to 100 files or fewer by splitting it into smaller PRs or changing its base branch. Upgrade to a paid plan to raise the limit. This review couldn't start because sufficient usage credits or metered capacity aren't available. Add credits or update usage-based reviews in the billing tab, then retry. ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Advanced Run ID: ⛔ Files ignored due to path filters (3)
📒 Files selected for processing (221)
You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
❌ 1 blocking issue (100 total)
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5dcc48cd10
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
ski-sketch
approved these changes
Sep 26, 2026
DefinetlyNotAI
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Prerequisites
--devflag, if required. (Not applicable: v4 has no--devflag.)PR Type
Description
Merge Logicytics v4.0.0 into
main. This release replaces the legacy script-based workflow with a typed pipeline for collector validation and planning, isolated collection, registered artifacts, run manifests, and verified packages. It adds profiles, capability and authorization controls, opt-in plugins, USB workflows, and a new CLI and documentation set.The configuration, output layout, and extension contracts have changed. The migration guide documents supported legacy inputs and aliases; legacy MOD support has been removed.
Motivation and Context
The legacy shared-script workflow lacked a consistent boundary for validation, authorization, failure isolation, and evidence tracking. V4 establishes those contracts so collection results are easier to inspect and failures remain visible without invalidating independent collectors.
Credit
No additional contributors to credit for this release merge. Existing attribution is retained in
.github/CREDITS.md.Issues Fixed
N/A