Repository navigation
refactor!: Remove the flexible-csv format - #421
Merged
Merged
Conversation
Signed-off-by: Ferenc Csaky <ferenc@datasqrl.com>
12 of 16 tasks
ferenc-csaky
force-pushed
the
refactor/flexible-csv-remove-skip-header
branch
from
October 19, 2026 20:05
efddb9b to
4af5a67
Compare
ferenc-csaky
added a commit
that referenced
this pull request
Oct 21, 2026
Signed-off-by: Ferenc Csaky <ferenc@datasqrl.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
Removes the
flexible-csvformat. Its only addition over Flink'scsvformat was theskip-headeroption. DataSQRL no longer infers the schema of CSV files, and it copies data files unchanged (DataSQRL/sqrl#2476), so CSV sources declare their columns and their files have no header row. Withoutskip-header,flexible-csvis the same ascsv.formats/flexible-csv-formatmodule, includingFlexibleCsvand the per-file header skipping from fix(flexible-csv): Skip the CSV header once per file instead of once per split #417 (FlexibleCsvFileFormat,FlexibleCsvBulkFormat) with their tests. Also its dependency inflink-sql-runner/pom.xmland its entry inFactoryAutoServiceTest.README.md: removes the CSV Format section and the "Additional configuration options for CSV format" feature bullet.CLAUDE.mdno longer lists the module.Breaking change
Tables with
'format' = 'flexible-csv'fail with Flink'sCould not find any factory for identifier 'flexible-csv' that implements '...DeserializationFormatFactory' in the classpath.. To migrate:'format' = 'csv'.flexible-csv.*options tocsv.*.skip-header, and remove header rows from the data.This also removes the old Kafka behaviour, where
skip-header = trueby default dropped the first record each reader decoded.Area
flink-sql-runner)connectors)formats)stdlib)env-utils)testing)README.md,stdlib-docs)How did you test it?
mvn compile -pl flink-sql-runner -ampasses, so nothing else referenced the module.FactoryAutoServiceTestpasses.mvn spotless:checkpasses.git grep -i flexible-csvfinds nothing.Checklist
feat:,fix:ordocs:, optionally with a scope (e.g.fix(flexible-json):)mvn clean installpasses locally and the code is formatted withmvn spotless:apply(formatted; ran only the builds above, with-Dlicense.skip=truebecause the license plugin can't read a git worktree)given_when_thennaming, AssertJ assertions) (removal only)pom.xml(no new dependencies)git commit -s -S)README.mdandstdlib-docsare updated if user-facing behavior or functions changed🤖 Generated with Claude Code