Repository navigation
Conversation
Run isolated dependent-flag fixtures through the existing parametric FFE evaluation path while keeping every SDK disabled until its supporting release is known. Environment: Datadog workspace Co-Authored-By: Codex GPT-5 <noreply@localhost>
Contributor
|
|
Contributor
|
⏳ PR checks are still running. This summary will update when all results arrive. 🎉 All green!🧪 All tests passed 🔗 Commit SHA: 246c918 | Docs | View more details | Give us feedback! |
Enable the direct dependent-flags method for the 7.0.0-pre SDK integration branch carrying the pinned WIP evaluator bundle. Environment: Datadog workspace Co-Authored-By: Codex GPT-5 <noreply@localhost>
…direct-system-tests # Conflicts: # manifests/golang.yml # manifests/java.yml # manifests/nodejs.yml # manifests/php.yml # manifests/python.yml # manifests/ruby.yml
typotter
marked this pull request as ready for review
October 27, 2026 21:02
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Run against the Node tracer artifact branch containing openfeature-js-client PR #437 at df51d65f0d89dc192c9c96cf7ac000dcf9ac1f43.
leoromanovsky
approved these changes
Oct 28, 2026
Keep the direct dependent-flags harness disabled for every SDK so activation and tracer branch targeting remain in the stacked integration PR.
Trigger system-tests CI after removing the Node target-branch selector from the pull request title.
typotter
enabled auto-merge (squash)
October 28, 2026 16:37
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Add direct dependent-flags evaluation coverage to the existing parametric FFE suite while keeping SDK activation and tracer branch targeting in a separate stacked integration PR.
Changes
test_ffe_dependent_flagsmethod beside the existing dynamic-evaluation testtests/parametric/test_ffe/dependent-flags/value,reason, anderrorCodefields provided by each case, while rejecting unexpected errors from successful evaluationsmissing_feature (FFL-1694)for every server SDKtest_ffe_flag_evaluationunchangedThe fixtures are an exact copy of
evaluation-suites/dependent-flagsfromDataDog/ffe-system-test-datacommitf20ab80(the merge of PR #45).SDK activation, Node tracer artifact selection, and target-branch CI execution are intentionally outside this harness PR and belong in the stacked activation PR.
Telemetry remains outside this system-test assertion. Exposure and flag-evaluation telemetry are covered in the SDK repository.
Validation
./format.shtest_ffe_dependent_flagsasmissing_feature (FFL-1694)