Skip to content

test: cover dependent parent with no assignment - #59

Closed
typotter wants to merge 2 commits into
mainfrom
typo/dependent-no-assignment-fixtures
Closed

typotter wants to merge 2 commits into
mainfrom
typo/dependent-no-assignment-fixtures

Conversation

@typotter

Copy link
Copy Markdown
Contributor

Motivation

Define the distinction between a failed prerequisite and a prerequisite that evaluates successfully but produces no assignment.

A prerequisite returning DEFAULT without a variant makes its dependency condition not match. Evaluation may continue to a later root allocation. Missing flags and evaluation errors still fail the dependency graph.

Changes

  • Add an unassigned prerequisite with no allocations.
  • Add a dependent root that falls back when the prerequisite has no variant.
  • Assert evaluation telemetry for both flags.
  • Assert that only the root fallback exposure is published.

Decisions

  • No assignment is represented by an absent variant, not a synthetic null variant.
  • Both ONE_OF and NOT_ONE_OF conditions treat no assignment as non-matching.

Checklist

  • JSON files are valid
  • New test cases reference existing suite flags
  • New flags have corresponding test cases
  • Expected results match the flag configuration logic

typotter and others added 2 commits October 30, 2026 17:32
Define no-assignment prerequisites as non-matching conditions that allow root fallback evaluation.

Environment: Datadog workspace

Co-Authored-By: Codex GPT-5 <noreply@localhost>
Exercise both membership operators against one memoized unassigned prerequisite.

Environment: Datadog workspace

Co-Authored-By: Codex GPT-5 <noreply@localhost>
@typotter
typotter marked this pull request as ready for review October 30, 2026 18:15
@typotter
typotter requested a review from a team as a code owner October 30, 2026 18:15
@typotter
typotter marked this pull request as draft October 30, 2026 18:17
@typotter typotter closed this Oct 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant