Repository navigation
[FFL-1795] Validate rejected dependency exposure not logged - #58
Merged
Merged
Conversation
Cover ONE_OF and NOT_ONE_OF dependency conditions whose evaluated prerequisite variant rejects the containing allocation. Preserve evaluation events while requiring that only the selected root fallback emits an exposure. Environment: Datadog workspace Co-Authored-By: Codex GPT-5 <noreply@localhost>
typotter
changed the title
hhan2024
approved these changes
Oct 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ONE_OFmiss andNOT_ONE_OFhit dependent-flag casesnoUnmatchedEventsThis closes the remaining contract gap called out in Helen’s review: the prerequisite is evaluated to determine that the condition is false, but no targeting rule is selected, so its exposure is not committed.
Validation
python3 -m unittest discover -s ci -p "test_*.py"git diff --check