Skip to content

ci: run all implemented debugger scenarios on PRs #4397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
p-datadog wants to merge 2 commits into
base: master
Choose a base branch
from
Open

ci: run all implemented debugger scenarios on PRs #4397

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
13a3663
ci: run all implemented debugger scenarios on PRs
p-ddsign Oct 28, 2026
a0ba64c
ci: extract the system-tests scenario loop into a generator helper
p-ddsign Oct 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 25 additions & 5 deletions .gitlab/generate-package.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,19 @@ function package_extension_jobs(array $platform, string $kind = "all"): array
return $jobs;
}

/**
* Emits a job script step that runs each listed system-tests scenario in sequence.
* Every scenario runs even when an earlier one fails; the step then fails, listing the failed scenarios.
*
* @param string $scenarios Shell words expanding to the scenario names: a variable reference such as '$TESTSUITE', or literal names.
*/
function system_tests_run_scenarios(string $scenarios): void
{
?>
- FAILED=""; for S in <?= $scenarios ?>; do echo "=== Running $S ==="; ./run.sh $S || FAILED="$FAILED $S"; done; if [ -n "$FAILED" ]; then echo "Failed scenarios:$FAILED"; exit 1; fi
<?php
}

$asan_build_platforms = [
[
"triplet" => "x86_64-unknown-linux-gnu",
Expand Down Expand Up @@ -1553,9 +1566,9 @@ function package_extension_jobs(array $platform, string $kind = "all"): array
- APPSEC_RUNTIME_ACTIVATION
- INTEGRATIONS
- CROSSED_TRACING_LIBRARIES
- DEBUGGER_PROBES_SNAPSHOT_WITH_SCM
- "DEBUGGER_PROBES_SNAPSHOT_WITH_SCM DEBUGGER_EXPRESSION_LANGUAGE DEBUGGER_INPRODUCT_ENABLEMENT"
script:
- ./run.sh $TESTSUITE
<?php system_tests_run_scenarios('$TESTSUITE') ?>

"System Tests: [php-fpm-8.5, default]":
extends: .system_tests
Expand All @@ -1578,9 +1591,16 @@ function package_extension_jobs(array $platform, string $kind = "all"): array
- APPSEC_RUNTIME_ACTIVATION
- INTEGRATIONS
- CROSSED_TRACING_LIBRARIES
- DEBUGGER_PROBES_SNAPSHOT_WITH_SCM
- "DEBUGGER_PROBES_SNAPSHOT_WITH_SCM DEBUGGER_TELEMETRY DEBUGGER_EXCEPTION_REPLAY"
script:
<?php system_tests_run_scenarios('$TESTSUITE') ?>

"System Tests: [apache-mod-8.0-zts, debugger]":
extends: .system_tests
variables:
BUILD_SH_ARGS: "-i weblog -w apache-mod-8.0-zts php"
script:
- ./run.sh $TESTSUITE
<?php system_tests_run_scenarios('DEBUGGER_PROBES_SNAPSHOT DEBUGGER_PII_REDACTION') ?>

<?php
$system_tests_weblogs = [
Expand Down Expand Up @@ -1644,7 +1664,7 @@ function package_extension_jobs(array $platform, string $kind = "all"): array
# Run this shard's packed scenarios that system-tests still lists, plus every CI_NODE_TOTAL-th (hash order) of those the durations file lacks.
- SCENARIOS=$(echo $SCENARIOS | python3 -c "import os,sys;n=int(os.environ['CI_NODE_TOTAL']);k=int(os.environ['CI_NODE_INDEX']);p=[os.environ.get(f'SHARD_{i}_SCENARIOS','').split() for i in range(1,n+1)];known={s for x in p for s in x};a=sys.stdin.read().split();print(' '.join([s for s in a if s in p[k-1]]+[s for s in a if s not in known][k-1::n]))")
- echo "Shard $CI_NODE_INDEX/$CI_NODE_TOTAL scenarios:" $SCENARIOS
- FAILED=""; for S in $SCENARIOS; do echo "=== Running $S ==="; ./run.sh $S || FAILED="$FAILED $S"; done; if [ -n "$FAILED" ]; then echo "Failed scenarios:$FAILED"; exit 1; fi
<?php system_tests_run_scenarios('$SCENARIOS') ?>

<?php endforeach; ?>
# THREAD_CONTEXT_SHARING needs CWS, which needs the kernel filesystems and the
Expand Down
Loading