Skip to content

feat(ffe): standardize evaluation-count environment variable - #4396

Draft
leoromanovsky wants to merge 1 commit into
masterfrom
leo/feature-flags-evaluation-counts-env-alias
Draft

leoromanovsky wants to merge 1 commit into
masterfrom
leo/feature-flags-evaluation-counts-env-alias

Conversation

@leoromanovsky

Copy link
Copy Markdown
Contributor

Description

Customers can disable aggregated evaluation-count delivery with DD_FEATURE_FLAGS_EVALUATION_COUNTS_ENABLED=false, using the same prefix as other Feature Flags settings. The existing DD_FLAGGING_EVALUATION_COUNTS_ENABLED remains a compatibility alias, with the canonical name taking precedence when both are set.

Use the native configuration alias mechanism for environment variables and INI settings. The default remains enabled; flag evaluation, experiment exposures, and the separate OpenTelemetry metric keep their existing behavior. The native alias matrix and both canonical/legacy kill-switch regression tests pass on PHP 8.1. Cross-version CI and central configuration registration remain pending.

Tracking: FFLSDK-275.

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

Prefer DD_FEATURE_FLAGS_EVALUATION_COUNTS_ENABLED while retaining the legacy name as a compatibility alias.

Environment: Datadog workspace
@linear-code

linear-code Bot commented Oct 28, 2026

Copy link
Copy Markdown

FFLSDK-275

@datadog-datadog-prod-us1-2

datadog-datadog-prod-us1-2 Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

Pipelines  Tests

✨ Unblock PR with BitsAI

❌ Errors

Your PR has failed checks. Please review the issues below and take necessary action before merging.

🚦 18 Pipeline jobs failed

DDCI - DataDog/dd-trace-php | test appsec extension: [7.0, amd64, debug-zts] — 🔧 Needs a code fix, caused by this PR

View more details · View in DDCI

DataDog/apm-reliability/dd-trace-php | framework test: [phpredis5] — 🔧 Needs a code fix, caused by this PR

View more details · View in GitLab

DataDog/apm-reliability/dd-trace-php | validate_supported_configurations_v2_local_file — 🔧 Needs a code fix, caused by this PR

View more details · View in GitLab

View all 18 failed jobs.

ℹ️ Info

No other issues found (see more)

🧪 All tests passed
❄️ No new flaky tests detected

🎯 Code Coverage (details)
• Patch Coverage: 100.00%
• Overall Coverage: 76.51% (+0.00%)

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 4057bba | Docs | View more details | Give us feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant