Repository navigation
Share MySQL container setup across WordPress AppSec suites - #4393
Merged
Merged
Conversation
🎉 All green!🧪 All tests passed 🎯 Code Coverage (details) 🔗 Commit SHA: e2ed4a5 | Docs | View more details | Give us feedback! |
estringana
force-pushed
the
estringana/improve-mysql-init-wordpress
branch
from
October 28, 2026 12:24
4c2753e to
2c9f755
Compare
Base automatically changed from
estringana/improve-mysql-init-wordpress
to
master
October 28, 2026 13:44
estringana
marked this pull request as ready for review
October 28, 2026 14:12
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
The four WordPress suites declared the same MySQL container (image, user, network alias, wait strategy) and only differed in the MySQL version and the database name. Build it with a newMysqlContainer() helper in AbstractWordPressAppsecTests instead. No change to the containers the suites start.
estringana
force-pushed
the
estringana/wordpress-mysql-container-helper
branch
from
October 28, 2026 14:13
a1edba1 to
e2ed4a5
Compare
estringana
enabled auto-merge (squash)
October 28, 2026 15:10
cataphract
approved these changes
Oct 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The four WordPress suites declared the same MySQL container (image, user, network alias, wait strategy) and only differed in the MySQL version and the database name. Build it with a newMysqlContainer() helper in AbstractWordPressAppsecTests instead.
No change to the containers the suites start.
Description
Reviewer checklist