Skip to content

Fix undefined locals in $locals exception property - #4389

Merged
bwoebi merged 1 commit into
masterfrom
bob/localsundef
Oct 28, 2026
Merged

bwoebi merged 1 commit into
masterfrom
bob/localsundef

Conversation

@bwoebi

@bwoebi bwoebi commented Oct 27, 2026

Copy link
Copy Markdown
Collaborator

Fixes #4382.

@bwoebi
bwoebi requested review from a team as code owners October 27, 2026 23:06
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-27T23:10:45.781981Z a76c96d PR opened
🔒 Security Review 🔄 Running since 2026-10-27T23:06:30.431442Z a76c96d PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@datadog-datadog-prod-us1-2 datadog-datadog-prod-us1-2 Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bits Code Review: FAIL

The new regression test throws ReflectionException on supported PHP 7.x–8.0 because it reads private exception properties without enabling reflection access.

Open Bits AI session

🤖 Bits Code Review · Commit a76c96d

Comment thread tests/ext/live-debugger/exception-replay_undefined_locals.phpt Outdated

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a76c96da79

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread tests/ext/live-debugger/exception-replay_undefined_locals.phpt Outdated
@datadog-datadog-prod-us1-2

datadog-datadog-prod-us1-2 Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

Tests

🎉 All green!

🧪 All tests passed
❄️ No new flaky tests detected

🎯 Code Coverage (details)
• Patch Coverage: 100.00%
• Overall Coverage: 74.35% (-2.16%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 7ea1f14 | Docs | View more details | Give us feedback!

@pr-commenter

pr-commenter Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

Benchmarks [ tracer ]

Benchmark execution time: 2026-10-28 15:38:12

Comparing candidate commit 7ea1f14 in PR branch bob/localsundef with baseline commit fbb1bb9 in branch master.

📊 Benchmarking dashboard

Found 0 performance improvements and 1 performance regressions! Performance is the same for 193 metrics, 0 unstable metrics.

Explanation

This is an A/B test comparing a candidate commit's performance against that of a baseline commit. Performance changes are noted in the tables below as:

  • 🟩 = significantly better candidate vs. baseline
  • 🟥 = significantly worse candidate vs. baseline

We compute a confidence interval (CI) over the relative difference of means between metrics from the candidate and baseline commits, considering the baseline as the reference.

If the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD), the change is considered significant.

Feel free to reach out to #apm-benchmarking-platform on Slack if you have any questions.

More details about the CI and significant changes

You can imagine this CI as a range of values that is likely to contain the true difference of means between the candidate and baseline commits.

CIs of the difference of means are often centered around 0%, because often changes are not that big:

---------------------------------(------|---^--------)-------------------------------->
                              -0.6%    0%  0.3%     +1.2%
                                 |          |        |
         lower bound of the CI --'          |        |
sample mean (center of the CI) -------------'        |
         upper bound of the CI ----------------------'

As described above, a change is considered significant if the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD).

For instance, for an execution time metric, this confidence interval indicates a significantly worse performance:

----------------------------------------|---------|---(---------^---------)---------->
                                       0%        1%  1.3%      2.2%      3.1%
                                                  |   |         |         |
       significant impact threshold --------------'   |         |         |
                      lower bound of CI --------------'         |         |
       sample mean (center of the CI) --------------------------'         |
                      upper bound of CI ----------------------------------'

scenario:MessagePackSerializationBench/benchMessagePackSerialization-opcache

  • 🟥 execution_time [+3.530µs; +5.310µs] or [+3.007%; +4.522%]

@bwoebi
bwoebi force-pushed the bob/localsundef branch 2 times, most recently from d69a0b6 to a099e43 Compare October 28, 2026 14:29
@bwoebi
bwoebi enabled auto-merge (squash) October 28, 2026 15:00
@bwoebi
bwoebi merged commit c836c89 into master Oct 28, 2026
2242 checks passed
@bwoebi
bwoebi deleted the bob/localsundef branch October 28, 2026 15:30
@github-actions github-actions Bot added this to the 1.27.0 milestone Oct 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Exception Replay produces invalid Symfony profiler serialization with Symfony 7.4.21

2 participants