Repository navigation
RUM-19232: Keep OpenFeature request failures recoverable - #4038
Draft
leoromanovsky wants to merge 1 commit into
Draft
leoromanovsky wants to merge 1 commit into
leoromanovsky wants to merge 1 commit into
Conversation
Map native Flags error states to GeneralError and verify recovery through OpenFeature status and flag evaluation. Ref: RUM-19232
Contributor
🎉 All green!🧪 All tests passed 🎯 Code Coverage (details) 🔗 Commit SHA: 0d1a7e9 | Docs | View more details | Give us feedback! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Map recoverable
FlagsClientState.Errorevents to OpenFeatureGeneralError. Preserve the error message and allow a later successful context update to restoreReady.Motivation
A network failure without usable cached assignments currently changes OpenFeature status to
Fatal. The native Flags client can recover. OpenFeature reservesPROVIDER_FATALfor irrecoverable failures.Ref: RUM-19232
Additional Notes
Test coverage includes error messages, an unknown cause, and recovery through public OpenFeature status and flag evaluation. All 80 provider tests and 83 Flags single-FIT tests passed. The single-FIT regression uses the real Flags client and OpenFeature SDK with stub transport and storage; it fails on the previous implementation.
The Foundation documentation check could not run because the local FactoryKit runtime is unavailable.
Review checklist (to be filled by reviewers)