[RUM-19223] Report each API usage telemetry once per SDK instance by aleksandr-gringauz · Pull Request #4037 · DataDog/dd-sdk-android

aleksandr-gringauz · 2026-10-23T13:34:09Z

What does this PR do?

Reporting usage telemetry logs only once so that we don't generate too much unnecessary telemetry.

Motivation

Additional Notes

Testing

Review checklist (to be filled by reviewers)

Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
Make sure you discussed the feature or bugfix with the maintaining team in an Issue
Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING.md doc)

PR by Bits - View session in Datadog • Open in Slack

Comment @DataDog to request changes

logApiUsage sent a usage event on every call, so volume scaled with how often apps call the API (e.g. operation steps). Deduplicate each usage type and configuration per SDK instance, before sampling. Ref: RUM-19223 Co-authored-by: aleksandr-gringauz <200633589+aleksandr-gringauz@users.noreply.github.com>

datadog-datadog-prod-us1-2 · 2026-10-23T13:34:11Z

View session in Datadog

Bits Code status: ✅ Done

CI Auto-fix: Disabled | Enable

Comment @DataDog to request changes

chatgpt-codex-connector · 2026-10-23T13:34:21Z

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-10-23T14:34:46.811850Z	`8f8c294`	New commits
🔒 Security Review	✅ Completed 2026-10-23T14:36:24.647464Z	`8f8c294`	New commits

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

aleksandr-gringauz · 2026-10-23T13:36:41Z

    private val onlyOnceMaintainerMessages = mutableSetOf<String>()
    private val onlyOnceTelemetryMessages = mutableSetOf<String>()

+    @Suppress("UnsafeThirdPartyFunctionCall") // the argument is always empty


don't suppress, put into the yaml detekt config responsible for it

@aleksandr-gringauz you need to use @\Datadog handle

I can only run on private repositories.

datadog-datadog-prod-us1-2

A usage call racing with RUM initialization can permanently suppress that usage’s telemetry, even when later calls occur after initialization completes.

_{Open Bits AI session}

_{🤖 Bits Code Review · Commit 9cf44db}

datadog-datadog-prod-us1-2 · 2026-10-23T13:39:24Z

        val event = apiUsageEventBuilder()
+        // Deduplicate before sampling, so that each usage gets a single sampling decision
+        // and the effective sample rate remains accurate.
+        if (!onlyOnceApiUsages.add(event.onlyOnceKey()) || !sample(samplingRate)) return


Wait for telemetry readiness before consuming the usage key

If WebViewTracking.enable races with Rum.enable, a sampled-in TrackWebView event can be dropped after its key is permanently consumed here. DatadogCore.registerFeature exposes RUM before initialization completes, and the global monitor is registered afterward; SdkFeature.sendEvent or the no-op monitor discards events during that interval. Later WebView tracking calls previously could report usage, but now remain suppressed for the SDK instance. Coordinate deduplication with telemetry readiness or buffer the first event; this requires changes across the logger and RUM initialization path.

React: 👍 useful · 👎 wrong · 😕 unclear · 👀 right, but not acting on it

What each reaction means

👍 Useful: correct, and you're fixing it or will.

👎 Wrong: the finding is incorrect, for example the bug can't happen or the code was misread.

😕 Unclear: you can't tell what it means or why it matters.

👀 Right, not acting: correct, but intended, out of scope for this PR, a known risk, or too minor.

_{🤖 Bits Code Review} _{· Open Bits AI session}

datadog-datadog-prod-us1-2 · 2026-10-23T13:41:44Z

🎉 All green!

🧪 All tests passed
❄️ No new flaky tests detected

🎯 Code Coverage (details)
• Patch Coverage: 100.00%
• Overall Coverage: 71.84% (+0.13%)

_{This comment will be updated automatically if new data arrives.

🔗 Commit SHA: beacc97 | Docs | View more details | Give us feedback!}

Replace the suppressed Collections.newSetFromMap with a ConcurrentHashMap and list its putIfAbsent call as a known safe call. Ref: RUM-19223 Co-authored-by: aleksandr-gringauz <200633589+aleksandr-gringauz@users.noreply.github.com>

Ref: RUM-19223 Co-authored-by: aleksandr-gringauz <200633589+aleksandr-gringauz@users.noreply.github.com>

Keep configuration only for usages that have one; other usages are keyed by type through an else branch. Ref: RUM-19223 Co-authored-by: aleksandr-gringauz <200633589+aleksandr-gringauz@users.noreply.github.com>

satween · 2026-10-26T09:53:22Z

    }

+    private fun allDistinctApiUsageEvents(): List<InternalTelemetryEvent.ApiUsage> {
+        val booleans = listOf(true, false)


nit: could be less nested

val addViewLoadingTimeEvents = List(8) { index -> InternalTelemetryEvent.ApiUsage.AddViewLoadingTime( overwrite = (index and 0b100) == 0, noView = (index and 0b010) == 0, noActiveView = (index and 0b001) == 0 ) }

aleksandr-gringauz requested review from a team as code owners October 23, 2026 13:34

datadog-official Bot added the Bits AI label Oct 23, 2026

aleksandr-gringauz commented Oct 23, 2026

View reviewed changes

datadog-datadog-prod-us1-2 Bot reviewed Oct 23, 2026

View reviewed changes

satween reviewed Oct 23, 2026

View reviewed changes

Comment thread ...k-android-core/src/main/kotlin/com/datadog/android/core/internal/logger/SdkInternalLogger.kt

datadog-bits and others added 2 commits October 23, 2026 13:59

RUM-19223: Explain configuration in API usage dedup key

15f359d

Ref: RUM-19223 Co-authored-by: aleksandr-gringauz <200633589+aleksandr-gringauz@users.noreply.github.com>

RUM-19223: Default API usage dedup key to the usage type

8f8c294

Keep configuration only for usages that have one; other usages are keyed by type through an else branch. Ref: RUM-19223 Co-authored-by: aleksandr-gringauz <200633589+aleksandr-gringauz@users.noreply.github.com>

aleksandr-gringauz added the ready-for-human-review All agentic review feedback was addressed and PR is ready for the human review. label Oct 26, 2026

aleksandr-gringauz requested review from 0xnm and satween October 26, 2026 09:28

0xnm changed the title ~~[RUM-19223] RUM-19223: Report each API usage telemetry once per SDK instance~~ [RUM-19223] Report each API usage telemetry once per SDK instance Oct 26, 2026

satween previously approved these changes Oct 26, 2026

View reviewed changes

0xnm reviewed Oct 26, 2026

View reviewed changes

Comment thread ...k-android-core/src/main/kotlin/com/datadog/android/core/internal/logger/SdkInternalLogger.kt Outdated

RUM-19223: Exhaustive when

beacc97

aleksandr-gringauz dismissed satween’s stale review via beacc97 October 26, 2026 16:34

0xnm approved these changes Oct 26, 2026

View reviewed changes

Navigation Menu

Repository navigation

[RUM-19223] Report each API usage telemetry once per SDK instance - #4037

[RUM-19223] Report each API usage telemetry once per SDK instance#4037
aleksandr-gringauz wants to merge 5 commits into
developfrom
dd/aleksandr-gringauz/RUM-19223/dedup-operation-usage-telemetry

aleksandr-gringauz commented Oct 23, 2026 •

edited

Loading

Uh oh!

datadog-datadog-prod-us1-2 Bot commented Oct 23, 2026 •

edited by datadog-prod-us1-3 Bot

Loading

Uh oh!

chatgpt-codex-connector Bot commented Oct 23, 2026 •

edited

Loading

Uh oh!

aleksandr-gringauz Oct 23, 2026

Uh oh!

0xnm Oct 23, 2026

Uh oh!

aleksandr-gringauz Oct 23, 2026

Uh oh!

datadog-datadog-prod-us1-2 Bot Oct 23, 2026

Uh oh!

datadog-datadog-prod-us1-2 Bot left a comment

Uh oh!

datadog-datadog-prod-us1-2 Bot Oct 23, 2026

Uh oh!

datadog-datadog-prod-us1-2 Bot commented Oct 23, 2026 •

edited by datadog-official Bot

Loading

Uh oh!

Uh oh!

satween Oct 26, 2026

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

aleksandr-gringauz commented Oct 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

Motivation

Additional Notes

Testing

Review checklist (to be filled by reviewers)

Uh oh!

datadog-datadog-prod-us1-2 Bot commented Oct 23, 2026 • edited by datadog-prod-us1-3 Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

chatgpt-codex-connector Bot commented Oct 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codex Review Summary

Uh oh!

aleksandr-gringauz Oct 23, 2026

Choose a reason for hiding this comment

Uh oh!

0xnm Oct 23, 2026

Choose a reason for hiding this comment

Uh oh!

aleksandr-gringauz Oct 23, 2026

Choose a reason for hiding this comment

Uh oh!

datadog-datadog-prod-us1-2 Bot Oct 23, 2026

Choose a reason for hiding this comment

Uh oh!

datadog-datadog-prod-us1-2 Bot left a comment

Choose a reason for hiding this comment

Uh oh!

datadog-datadog-prod-us1-2 Bot Oct 23, 2026

Choose a reason for hiding this comment

Uh oh!

datadog-datadog-prod-us1-2 Bot commented Oct 23, 2026 • edited by datadog-official Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

satween Oct 26, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

aleksandr-gringauz commented Oct 23, 2026 •

edited

Loading

datadog-datadog-prod-us1-2 Bot commented Oct 23, 2026 •

edited by datadog-prod-us1-3 Bot

Loading

chatgpt-codex-connector Bot commented Oct 23, 2026 •

edited

Loading

datadog-datadog-prod-us1-2 Bot commented Oct 23, 2026 •

edited by datadog-official Bot

Loading