RUM-19153: Migrate readers to shared RUM context by kikoveiga · Pull Request #4027 · DataDog/dd-sdk-android

kikoveiga · 2026-10-22T10:40:07Z

What does this PR do?

Migrates the remaining Android RUM context readers in Flags, Profiling, Trace, WebView, and Session Replay to the shared typed RumContext introduced in #4019. Replay and WebView cache the typed snapshot instead of the mutable feature map.

Motivation

RUM-19153: replace repeated field parsing with shared types, preparing for the context changes in #3970. #4019 has merged; this PR now targets develop.

Additional Notes

Legacy flat fields remain published for cross-platform consumers, including Flutter Session Replay. Updated tests use typed-only contexts. Affected unit and JVM integration suites, formatting, Detekt, and generated-file checks passed.

Review checklist (to be filled by reviewers)

Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
Make sure you discussed the feature or bugfix with the maintaining team in an Issue
Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

datadog-prod-us1-5 · 2026-10-22T10:45:37Z

🎉 All green!

🧪 All tests passed
❄️ No new flaky tests detected

🎯 Code Coverage (details)
• Patch Coverage: 68.29%
• Overall Coverage: 71.84% (-0.04%)

_{This comment will be updated automatically if new data arrives.

🔗 Commit SHA: 40fe938 | Docs | View more details | Give us feedback!}

kikoveiga · 2026-10-23T11:22:09Z

@codex review

chatgpt-codex-connector · 2026-10-23T11:22:33Z

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-10-23T16:09:54.065887Z	`40fe938`	New commits
🔒 Security Review	✅ Completed 2026-10-23T16:11:05.779028Z	`40fe938`	New commits

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

chatgpt-codex-connector · 2026-10-23T11:25:52Z

Codex Review: Didn't find any major issues. 👍

Reviewed commit: e9ae12aac4

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-10-23T11:27:24Z

🛡️ Codex Security Review · Automatically triggered

Security review completed. No security issues were found in this pull request.

Reviewed commit: e9ae12aac4

View security finding report

Only the user who started this review can view the report in Codex.

ℹ️ About Codex security reviews in GitHub

This is an experimental Codex feature. Security reviews are triggered when:

You comment "@codex security review"
A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review

Once complete, Codex will leave suggestions, or a comment if no findings are found.

kikoveiga · 2026-10-23T14:06:48Z

@codex review

chatgpt-codex-connector · 2026-10-23T14:09:39Z

Codex Review: Didn't find any major issues. You're on a roll.

Reviewed commit: 4915b79780

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-10-23T14:10:43Z

🛡️ Codex Security Review · Automatically triggered

Security review completed. No security issues were found in this pull request.

Reviewed commit: 4915b79780

View security finding report

Only the user who started this review can view the report in Codex.

ℹ️ About Codex security reviews in GitHub

This is an experimental Codex feature. Security reviews are triggered when:

You comment "@codex security review"
A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review

Once complete, Codex will leave suggestions, or a comment if no findings are found.

datadog-prod-us1-5

More details

The shared RUM publisher supplies the values expected by the migrated readers, while legacy flat fields remain available to cross-platform consumers. The completed static review identified no actionable regression.

Was this helpful? React 👍 or 👎

_{Open Bits AI session}

_{🤖 Bits Code Review · Commit 4915b79}

0xnm

worth getting one more approval

kikoveiga mentioned this pull request Oct 22, 2026

RUM-17009: Preserve application attribution without an active RUM session #3970

Draft

3 tasks

kikoveiga added this pull request to stack #4028 October 22, 2026 10:55

kikoveiga force-pushed the kikoveiga/RUM-19153/use-typed-rum-context branch from cdbf208 to 6c37d17 Compare October 23, 2026 08:53

kikoveiga mentioned this pull request Oct 23, 2026

RUM-17009: Extract shared RUM context into internal module #4019

Merged

3 tasks

Base automatically changed from kikoveiga/RUM-17009/extract-shared-rum-context to develop October 23, 2026 10:57

kikoveiga force-pushed the kikoveiga/RUM-19153/use-typed-rum-context branch 2 times, most recently from f4f6e96 to e9ae12a Compare October 23, 2026 11:22

kikoveiga force-pushed the kikoveiga/RUM-19153/use-typed-rum-context branch 7 times, most recently from fe11ef3 to 4915b79 Compare October 23, 2026 14:05

kikoveiga marked this pull request as ready for review October 23, 2026 14:31

kikoveiga requested review from a team as code owners October 23, 2026 14:31

datadog-prod-us1-5 Bot reviewed Oct 23, 2026

View reviewed changes

0xnm previously approved these changes Oct 23, 2026

View reviewed changes

Comment thread dd-sdk-android-core/src/testFixtures/kotlin/com/datadog/android/utils/DatadogContextUtils.kt Outdated

Comment thread ...k-android-flags/src/test/kotlin/com/datadog/android/flags/internal/EvaluationsFeatureTest.kt Outdated

RUM-19153: Migrate readers to shared RUM context

40fe938

kikoveiga dismissed 0xnm’s stale review via 40fe938 October 23, 2026 16:06

kikoveiga force-pushed the kikoveiga/RUM-19153/use-typed-rum-context branch from 4915b79 to 40fe938 Compare October 23, 2026 16:06

kikoveiga added the ready-for-human-review All agentic review feedback was addressed and PR is ready for the human review. label Oct 25, 2026

aleksandr-gringauz approved these changes Oct 26, 2026

View reviewed changes

kikoveiga requested a review from 0xnm October 26, 2026 12:10

0xnm approved these changes Oct 26, 2026

View reviewed changes

kikoveiga merged commit baa806b into develop Oct 26, 2026
28 checks passed

kikoveiga deleted the kikoveiga/RUM-19153/use-typed-rum-context branch October 26, 2026 12:12

Navigation Menu

Repository navigation

RUM-19153: Migrate readers to shared RUM context - #4027

RUM-19153: Migrate readers to shared RUM context#4027
kikoveiga merged 1 commit into
developfrom
kikoveiga/RUM-19153/use-typed-rum-context

kikoveiga commented Oct 22, 2026 •

edited

Loading

Uh oh!

datadog-prod-us1-5 Bot commented Oct 22, 2026 •

edited by datadog-official Bot

Loading

Uh oh!

kikoveiga commented Oct 23, 2026

Uh oh!

chatgpt-codex-connector Bot commented Oct 23, 2026 •

edited

Loading

Uh oh!

chatgpt-codex-connector Bot commented Oct 23, 2026

Uh oh!

chatgpt-codex-connector Bot commented Oct 23, 2026

Uh oh!

kikoveiga commented Oct 23, 2026

Uh oh!

chatgpt-codex-connector Bot commented Oct 23, 2026

Uh oh!

chatgpt-codex-connector Bot commented Oct 23, 2026

Uh oh!

datadog-prod-us1-5 Bot left a comment

Uh oh!

0xnm left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

kikoveiga commented Oct 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

Motivation

Additional Notes

Review checklist (to be filled by reviewers)

Uh oh!

datadog-prod-us1-5 Bot commented Oct 22, 2026 • edited by datadog-official Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kikoveiga commented Oct 23, 2026

Uh oh!

chatgpt-codex-connector Bot commented Oct 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codex Review Summary

Uh oh!

chatgpt-codex-connector Bot commented Oct 23, 2026

Uh oh!

chatgpt-codex-connector Bot commented Oct 23, 2026

🛡️ Codex Security Review · Automatically triggered

Uh oh!

kikoveiga commented Oct 23, 2026

Uh oh!

chatgpt-codex-connector Bot commented Oct 23, 2026

Uh oh!

chatgpt-codex-connector Bot commented Oct 23, 2026

🛡️ Codex Security Review · Automatically triggered

Uh oh!

datadog-prod-us1-5 Bot left a comment

Choose a reason for hiding this comment

Uh oh!

0xnm left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

kikoveiga commented Oct 22, 2026 •

edited

Loading

datadog-prod-us1-5 Bot commented Oct 22, 2026 •

edited by datadog-official Bot

Loading

chatgpt-codex-connector Bot commented Oct 23, 2026 •

edited

Loading