Repository navigation
FFL-3355: Add independent native flag tracking operations - #4012
gh-worker-dd-mergequeue-cf854d[bot] merged 8 commits into
Conversation
🎉 All green!🧪 All tests passed 🎯 Code Coverage (details) 🔗 Commit SHA: 6cca780 | Docs | View more details | Give us feedback! |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![datadog-official[bot]](https://avatars.githubusercontent.com/in/1358509?s=60&v=4){kind=small}
There was a problem hiding this comment.
More details
The independent tracking operations preserve configuration gates and existing event-processing paths, while combined tracking retains its RUM behavior. No actionable correctness issues were identified.
🤖 Bits Code Review · Commit b14b48a
|
|
||
| @Test | ||
| fun `M do nothing W independent hooks called {fallback client}`() { | ||
| // Given |
There was a problem hiding this comment.
looks like tests in this class misses verification block
There was a problem hiding this comment.
The fallback-client test previously checked for no exceptions implicitly, since any exception would fail the test.
Commit 11ebea0 makes that expectation explicit with assertDoesNotThrow. It also adds explicit verifyNoInteractions assertions to the skipped-tracking tests, which previously relied on the shared @AfterEach verification.
Merge current develop, regenerate the Flags API snapshots, and cover telemetry opt-out for independent tracking hooks. Ref: FFL-3355
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 705ac1aadd
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Add the standard Mockito strictness annotation and name the exercised tracking methods explicitly. Ref: FFL-3355
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e899563bc1
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Add parentheses to both methods in the telemetry opt-out test name. Ref: FFL-3355
Test global and per-subject tracking opt-out through the RN proxy. Share the policy check, extract allowed error codes, and clarify tracking documentation and test naming. Ref: FFL-3355
Add an independent RUM tracking bridge that honors the native client's telemetry policy and RUM integration setting. Cover opt-out and fallback behavior and update API snapshots. Ref: FFL-3355
gh-worker-dd-devflow-36fce6
Bot
added
mergequeue-status: queued
mergequeue-status: in_progress
and removed
mergequeue-status: queued
labels
What does this PR do?
Add independent native exposure and evaluation tracking operations through
_FlagsInternalProxy(FFL-3355).trackFlagExposureandtrackFlagEvaluationEventwithout fetching or replacing configuration.trackFlagSnapshotEvaluationbehavior, including RUM integration.GENERAL.Motivation
React Native OpenFeature hooks must select exposure logging, evaluation logging, and RUM tracking independently. The combined bridge operation cannot provide that selection without unwanted or duplicate tracking.
This PR is a prerequisite for DataDog/dd-sdk-reactnative#1507, which uses these APIs for independently selectable OpenFeature tracking hooks. The RN PR must update its Android SDK dependency to a release containing these changes before merging/releasing.
Additional Notes
FlagsTrackingBridgeTestcases for independent selection, preserved combined behavior, defaults/errors,doLog, all four exposure/evaluation configuration combinations, and no-op clients. Ktlint and detekt also pass.b14b48a4b.devflow/mergegateremains pending.Review checklist (to be filled by reviewers)