Repository navigation
Make ClassFile parsing of super-name more robust - #160
Merged
Merged
Conversation
mcculls
changed the title
mcculls
force-pushed
the
mcculls/allow-jlo-classfile
branch
from
October 30, 2026 12:19
5d4ff4a to
bb10aee
Compare
mcculls
marked this pull request as ready for review
October 30, 2026 12:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do
Handle a zero
super_classindex when parsing class headers and outlines, returning a null superclass forjava.lang.Objectand modules. Update theClassHeader.superNamedocumentation and add regression tests for Object, module descriptors, and module descriptors withACC_SYNTHETIC.Motivation
The previous superclass lookup did not handle
java.lang.Object, and its exact access-flag comparison only recognized modules without additional flags. Checking the superclass offset handles both cases.Additional Notes
Validation:
./gradlew :class-match:check --no-configuration-cachepassed, including tests on Java 8, 11, 17, 21, and 25, formatting, and SpotBugs. Configuration caching was disabled to work around a Spotless configuration-cache serialization error.Contributor Checklist
Jira ticket: not provided.