Repository navigation
ci: ignore the FIPS-blocked rustls advisories in the Trivy lockfile scan - #1481
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
Suppressing three known TLS advisories requires security/FIPS owner confirmation of risk acceptance and the AWS-LC-FIPS certification constraint, which repository inspection alone cannot establish.
No open issues 🎉
What changed in this PR
Updates the Trivy lockfile scan’s ignore list to cover three rustls advisories whose fixes are blocked by pending AWS-LC-FIPS 4.x certification.
Changes:
- Adds three GHSA entries matching the configured Rust advisory ignores.
- Documents the upgrade constraint and directs removal alongside the corresponding Rust advisory ignores.
| File | Description |
|---|---|
.trivyignore.yaml |
Adds three rustls advisory exceptions with rationale and removal guidance. |
Review effort: Balanced
litianningdatadog
approved these changes
Oct 28, 2026
lucaspimentel
approved these changes
Oct 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Jira: SVLS-9989
The Trivy
Lockfile Scanfails onmainand on every PR. It flags 3 rustls 0.23.43 advisories:Debugimpls for client session values expose TLS secretsThe Rust advisory check (
Audit) already ignores these 3, for the same reason as GHSA-2mjx-qc3c-rqvc (RUSTSEC-2026-0285), which is already in.trivyignore.yaml. The fix is rustls >= 0.23.46. That version needs aws-lc-rs >= 1.18, which moves thefipsbuild to the AWS-LC-FIPS 4.0 module. NIST has not certified AWS-LC-FIPS 4.0 yet; it is still in review. The certified modules are 3.x and older.This PR adds the 3 GHSA ids to
.trivyignore.yamlwith that reason, so the two ignore lists match again. Remove all 4 rustls entries, and the matching Rust advisory ignores, when AWS-LC-FIPS 4.0 is certified and rustls is bumped.It does not depend on any other PR. It touches the same file as #1469, so the second one to merge needs a small rebase.
Testing
Ran the same scan as the
Lockfile Scanjob (trivy 0.69.3,fs bottlecap,--ignore-unfixed,--exit-code 1, this ignore file):main: exit 1,Total: 3 (LOW: 2, MEDIUM: 1), the 3 GHSA ids above..trivyignore.yamlparses as YAML with 5 entries.