Repository navigation
ci(gitlab): non-blocking binary size report against main - #1480
Open
duncanista wants to merge 1 commit into
Open
duncanista wants to merge 1 commit into
duncanista wants to merge 1 commit into
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
lym953
approved these changes
Oct 28, 2026
duncanista
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR: A non-blocking GitLab job that compares each pipeline's binary with main's (from #1476) and prints the size change.
Why: A size regression shows up in the pipeline before it ships, instead of after a release. It only warns and never blocks.
Overview
Jira: SVLS-9976
Stacked on #1479 (
jordan.gonzalez/dev-binary-report/feature).Add the job
binary report (<flavor>)afterbottlecap (<flavor>), for the flavors withkeep_symbols..gitlab/scripts/binary_report.pydownloads the latestmainartifact ofbottlecap symbols (<flavor>)with the job token, runsscripts/dev/binary-report.sh --diff --no-crates, and writes a markdown table to the job logand to
.binary-report/(report.json,report.md,metrics.txtas a GitLab metricsreport).
The job never fails on a number (
allow_failure: true). A growth overBINARY_SIZE_WARN_KIB(256) prints aWARNINGline. It does not comment on the GitHub PR,because that needs a token.
Size: 219 core lines, 219 lines in total.
Testing
.gitlab/templates/pipeline.yaml.tpl, parsed as YAML: passpython3 -m py_compile: passmainwith the published binary: +125,136 B (+1.23 %).