Repository navigation
Conversation
These tests ran the Go extension built from datadog-agent next to a recorder extension, also from datadog-agent. datadog-agent deleted the Lambda extension code and the recorder script in #42994 (2025-11), so the setup cannot build. Bots still open dependency PRs for local_tests/golang. Keeps the bottlecap tests: bottlecap/, managed-instance/ and the large-payload repro. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
❌ ErrorsYour PR has failed checks. Please review the issues below and take necessary action before merging. 🚦 2 Pipeline jobs failed
Useful? React with 👍 / 👎 This comment will be updated automatically if new data arrives.🔗 Commit SHA: f2c4879 | Docs | View more details | Give us feedback! |
lym953
marked this pull request as ready for review
October 27, 2026 15:37
lym953
requested review from
shreyamalpani
and
a balanced review from Copilot
October 27, 2026 15:37
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The cleanup is isolated to unused legacy test infrastructure, with no remaining consumers identified and Bottlecap’s test workflows preserved.
No open issues 🎉
What changed in this PR
Removes obsolete local test infrastructure for the retired Go extension while preserving Bottlecap’s tests. Deleting the unused Go module also eliminates a source of unnecessary dependency-update PRs.
Changes:
- Deletes legacy build and invocation scripts.
- Removes Go, Python, Node.js, and Java test functions and their Dockerfiles.
- Removes ignore rules for artifacts produced by the deleted setup.
| File | Description |
|---|---|
local_tests/python-timeout.Dockerfile |
Deletes the legacy Python timeout image. |
local_tests/java/src/main/resources/log4j.properties |
Removes Java test logging configuration. |
local_tests/java/src/main/java/com/serverless/Handler.java |
Deletes the Java test handler. |
local_tests/java/README.md |
Removes instructions for the deleted Java setup. |
local_tests/java/gradle/wrapper/gradle-wrapper.properties |
Removes legacy Gradle wrapper configuration. |
local_tests/java/build.gradle |
Removes Java test dependencies and packaging. |
local_tests/java/api-gateway.json |
Deletes the Java invocation fixture. |
local_tests/invoke.sh |
Deletes the legacy container invocation script. |
local_tests/golang/main.go |
Deletes the Go test handler. |
local_tests/golang/go.sum |
Removes unused Go dependency checksums. |
local_tests/golang/go.mod |
Removes the obsolete Go test module. |
local_tests/func.py |
Deletes the Python test handler. |
local_tests/func.js |
Deletes the Node.js test handler. |
local_tests/Dockerfile.Python |
Deletes the legacy Python test image. |
local_tests/Dockerfile.Node |
Deletes the legacy Node.js test image. |
local_tests/Dockerfile.Java |
Deletes the legacy Java test image. |
local_tests/Dockerfile.Go |
Deletes the legacy Go test image. |
local_tests/build-docker-runtime.sh |
Removes legacy test-image build orchestration. |
.gitignore |
Removes obsolete artifact rules while retaining the agent-binary rule. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
These local tests run the earlier Go extension. That extension is deleted, and the extension is now bottlecap, so nothing runs these tests. All the deleted files were added between January 2022 and September 2023, before bottlecap's first commit in April 2024 (#202). Bots still open dependency PRs for the Go test function, for example #1419, #1446 and #1462.
This PR
Deletes the Go extension's local test setup:
build-docker-runtime.sh,invoke.sh, the Go, Python, Node.js and Java test functions with their Dockerfiles, and their.gitignoreentries. The bottlecap tests stay.Testing
git grepon the branch finds no references to the deleted files.🤖 Generated with Claude Code