Repository navigation
fix(deps): vuln minor upgrades — 10 packages (minor: 4 · patch: 6) [integration-tests/package.json] - #1459
Conversation
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
🟡 Changes recommended
The committed lockfile retains versions incompatible with the manifest’s overrides, leaving the YAML remediation unapplied and the dependency graph inconsistent for CI’s npm ci workflow.
1 open issue
1 file not reviewed
integration-tests/package-lock.json: Generated file
What changed in this PR
This PR updates dependencies used by the Datadog Lambda Extension’s integration tests to address reported security vulnerabilities.
Changes:
- Raises Axios and AWS CDK dependency versions.
- Adds targeted protobufjs and js-yaml overrides and revises existing overrides.
- Updates locked dependencies, including Handlebars, follow-redirects, and brace-expansion, and removes CDK’s bundled fast-uri dependency.
| File | Description |
|---|---|
integration-tests/package.json |
Updates direct dependency ranges and transitive dependency overrides. |
integration-tests/package-lock.json |
Records dependency upgrades and changes to the resolved dependency tree. |
Review effort: Balanced
| } | ||
| }, | ||
| "node_modules/@aws-sdk/xml-builder/node_modules/fast-xml-parser": { | ||
| "version": "5.7.3", |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e631a3f234
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| "fast-xml-builder": "^1.1.9" | ||
| "fast-xml-parser": "^5.8.0" | ||
| }, | ||
| "jest": { |
There was a problem hiding this comment.
Keep the Jest override tree installable with npm 11
With npm 11.4.2, a clean npm ci --ignore-scripts --no-audit --no-fund in integration-tests now exits with Invalid Version while resolving the newly added Jest/ts-jest override graph, so affected development and CI environments cannot install or run these integration tests. The parent manifest gets past dependency resolution, and deleting both new Jest override blocks from this revision does as well; please replace the deeply duplicated override graph with an npm-11-compatible override and regenerate the lockfile.
Useful? React with 👍 / 👎.
| "node_modules/@aws-sdk/xml-builder/node_modules/fast-xml-parser": { | ||
| "version": "5.7.3", | ||
| "resolved": "https://registry.npmjs.org/fast-xml-parser/-/fast-xml-parser-5.7.3.tgz", |
There was a problem hiding this comment.
Preserve the fast-xml-parser minimum in the lockfile
The manifest still overrides fast-xml-parser to ^5.8.0 beneath all six AWS clients, but this regenerated lockfile replaces the previous hoisted 5.9.0 resolution with 5.7.3 under their shared @aws-sdk/xml-builder. Lockfile-based installs can therefore use a parser below the explicitly retained minimum, undoing that dependency mitigation for AWS XML processing; override the shared XML builder path or retain a compatible resolution at or above 5.8.0.
Useful? React with 👍 / 👎.
| "@jest/transform": { | ||
| "babel-plugin-istanbul": { | ||
| "@istanbuljs/load-nyc-config": { | ||
| "js-yaml": "^3.15.2" |
There was a problem hiding this comment.
Actually resolve the requested js-yaml upgrade
All of the newly added Jest/Istanbul paths request js-yaml ^3.15.2, but the regenerated lockfile still contains only node_modules/js-yaml 3.14.2. The integration-test pipeline runs npm ci from this lockfile at .gitlab/templates/pipeline.yaml.tpl:660, so even in the npm 10 environment where installation succeeds, the intended dependency remediation is not present in the installed Jest coverage chain; regenerate the lockfile so its selected js-yaml version satisfies the override.
Useful? React with 👍 / 👎.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
…ation-tests/package.json] Co-authored-by: gh-worker-campaigns-3e9aa4[bot] <244854796+gh-worker-campaigns-3e9aa4[bot]@users.noreply.github.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: lym953 <10097700+lym953@users.noreply.github.com>
CI installs with npm 10, which rejects the lock file that the bot wrote for the new overrides. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: lym953 <10097700+lym953@users.noreply.github.com>
aws-cdk-lib 2.274.0 writes cloud assembly schema 55, which aws-cdk 2.1127.0 cannot read, so every cdk deploy failed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: lym953 <10097700+lym953@users.noreply.github.com>
Co-authored-by: gh-worker-campaigns-3e9aa4[bot] <244854796+gh-worker-campaigns-3e9aa4[bot]@users.noreply.github.com>
Auto-rebase completeBranch is up to date with Auto-Rebase · Add |
e631a3f to
d3b89ca
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d3b89ca9dd
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| "version": "3.14.2", | ||
| "resolved": "https://registry.npmjs.org/js-yaml/-/js-yaml-3.14.2.tgz", | ||
| "integrity": "sha512-PMSmkqxr106Xa156c2M265Z+FTrPl+oxd/rgOQy2tijQeK5TxQ43psO1ZCwhVOSdnn+RzkzlRz/eY4BgJBYVpg==", | ||
| "version": "3.15.2", |
There was a problem hiding this comment.
Use a js-yaml release that fixes all listed advisories
When Jest coverage loads a crafted YAML nyc configuration, locking js-yaml to 3.15.2 still leaves the advertised GHSA-5p4m-2wfm-xmqj and GHSA-2883-xcg3-v3hh CPU-denial-of-service issues unfixed; the security details identify their fixes as 4.3.1 and 4.3.2 respectively. Upgrade the coverage dependency chain so it can resolve at least 4.3.2 rather than reporting the js-yaml remediation as complete with a vulnerable 3.x release.
AGENTS.md reference: AGENTS.md:L18-L23
Useful? React with 👍 / 👎.
| "version": "1.1.15", | ||
| "resolved": "https://registry.npmjs.org/brace-expansion/-/brace-expansion-1.1.15.tgz", | ||
| "integrity": "sha512-EwOCDEex4quD37XhqM3omwtMoJjr//isUZz1JopUNWms+4Z2ViyM/k1YIRePpoVNnQhENnxtFjLaxNHrT7xIUg==", | ||
| "version": "1.1.21", |
There was a problem hiding this comment.
Resolve the advertised browser-data security upgrades
On every lockfile-based install, this regenerated hunk still leaves the neighboring browserslist and baseline-browser-mapping entries at 4.28.2 and 2.10.37, although the PR summary advertises upgrades to 4.28.9 and 2.11.32 to address their denial-of-service vulnerabilities. Regenerate or override this dependency chain so clean npm ci installs contain the remediated versions rather than reporting upgrades that never landed.
AGENTS.md reference: AGENTS.md:L18-L23
Useful? React with 👍 / 👎.
| } | ||
| }, | ||
| "node_modules/@opentelemetry/exporter-trace-otlp-http/node_modules/@opentelemetry/core": { | ||
| "version": "1.29.0", |
There was a problem hiding this comment.
Honor the OpenTelemetry core override in the lockfile
The manifest retains an @opentelemetry/exporter-trace-otlp-http override requiring @opentelemetry/core ^1.30.1, but this newly added nested node resolves 1.29.0. The resulting virtual dependency tree marks the exporter's overridden core edge invalid, so lockfile-based installs no longer reproducibly enforce the explicit minimum; regenerate the lockfile with 1.30.1 throughout the overridden exporter subtree.
Useful? React with 👍 / 👎.

Summary: Critical-severity security update — 10 packages upgraded (MINOR changes included)
Manifests changed:
integration-tests/package.json(npm)✅ Action Required: Please review the changes below. If they look good, approve and merge this PR.
Updates
Security Details
🚨 Critical & High Severity (67 fixed)
ℹ️ Other Vulnerabilities (30)
{a},b}rewrite causes CPU denial of service{a},b}rewrite causes CPU denial of service{a},b}rewrite causes CPU denial of service{a},b}rewrite causes CPU denial of serviceReview Checklist
Standard review:
Update Mode: all_vulns
🤖 Generated by DataDog Automated Dependency Management System