Skip to content

👷 move the pipeline category when closing or reopening a ticket in the triage skill - #5191

Open
mormubis wants to merge 2 commits into
mainfrom
adlrb/triage-skill-close-category
Open

mormubis wants to merge 2 commits into
mainfrom
adlrb/triage-skill-close-category

Conversation

@mormubis

Copy link
Copy Markdown
Contributor

Motivation

Follow up to #5169. When the triage skill closes or reopens a ticket, it only does the Jira transition. The Confluence page says the pipeline category moves too, so a Done ticket can keep its logs tagged as needs investigation.

Changes

The close and reopen step now also moves the pipeline category to the matching status, and shows it for approval like the transition. It is one line in .claude/skills/triaging-telemetry-errors/SKILL.md. I drafted the wording with an AI agent, please review.

Test instructions

  1. Load the skill in Claude Code and ask it to close a telemetry error ticket as fixed.
  2. Check that it proposes the Jira transition and the category move to done, pinned to the versions before the fix.
  3. Check that it applies neither until you approve.

Checklist

  • Tested locally
  • Tested on staging
  • Added unit tests for this change.
  • Added e2e/integration tests for this change.
  • Updated documentation and/or relevant AGENTS.md file

@mormubis
mormubis requested a review from a team as a code owner October 27, 2026 15:23
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-27T15:25:28.502050Z ccb8365 PR opened
🔒 Security Review ✅ Completed 2026-10-27T15:25:36.886391Z ccb8365 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@cit-pr-commenter-54b7da

Copy link
Copy Markdown

Bundles Sizes Evolution

📦 Bundle Name Base Size Local Size 𝚫 𝚫% Status
Rum Salesforce 188.93 KiB 188.93 KiB 0 B 0.00% ✅
Rum 188.91 KiB 188.91 KiB 0 B 0.00% ✅
Rum Salesforce Profiler 8.35 KiB 8.35 KiB 0 B 0.00% ✅
Rum Profiler 8.35 KiB 8.35 KiB 0 B 0.00% ✅
Rum Salesforce Recorder 32.04 KiB 32.04 KiB 0 B 0.00% ✅
Rum Recorder 32.04 KiB 32.04 KiB 0 B 0.00% ✅
Logs 59.37 KiB 59.37 KiB 0 B 0.00% ✅
Rum Slim 146.52 KiB 146.52 KiB 0 B 0.00% ✅
Worker 22.96 KiB 22.96 KiB 0 B 0.00% ✅
Rum Shopify 219.35 KiB 219.35 KiB 0 B 0.00% ✅
Rum Shopify Profiler 8.35 KiB 8.35 KiB 0 B 0.00% ✅
Rum Shopify Recorder 4.85 KiB 4.85 KiB 0 B 0.00% ✅

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ccb8365d4a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

- The Atlassian MCP create call only takes the summary and a plain-text description: set the other fields right after with an update, and write the description in Atlassian Document Format so headings, lists and links render (add the Log Explorer links once the key exists).
- After creation, use the new key as the pipeline category name.
- Closing or reopening a ticket follows the same rule: show the transition and the comment (reason, 24h count or fixed version) and apply it only after approval.
- Closing or reopening a ticket also moves its pipeline category to the matching status: won't do, done (pinned to the versions before the fix) or, when reopening, needs investigation. Show the transition, the comment (reason, 24h count or fixed version) and the category move, and apply each only after approval.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Revalidate the version pin when reopening

issue: When a Done ticket is reopened because the fix did not hold on newer SDK versions, merely moving its existing category to needs investigation preserves the Done query's old pre-fix version pin. The recurring errors will therefore remain untagged and absent from the known-issue sample even though the ticket is open again. Explicitly require updating or removing the stale pin when moving a Done category back to needs investigation.

Useful? React with 👍 / 👎.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated!

@datadog-datadog-prod-us1 datadog-datadog-prod-us1 Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bits Code Review: PASS

More details

The close/reopen instruction preserves approval for each Jira and pipeline write and requires fixed-issue categories to remain pinned to pre-fix versions. The completed static review found no reportable defect.

Was this helpful? React 👍 or 👎

Open Bits AI session

🤖 Bits Code Review · Commit ccb8365

@datadog-datadog-prod-us1

datadog-datadog-prod-us1 Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

Pipelines  Tests

🎉 All green!

🧪 All tests passed
❄️ No new flaky tests detected

🎯 Code Coverage (details)
• Patch Coverage: 100.00%
• Overall Coverage: 77.27% (+0.00%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 4827fdd | Docs | View more details | Give us feedback!

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants