Repository navigation
Conversation
The Datadog build plugin uploads each build's function list to Live Debugger under a service, and Live Debugger finds it by the service the SDK reports, so both have to match. The build plugin now also writes its service (`liveDebugger.service`) into `__DD_LIVE_DEBUGGER_BUILD__`. Default `init().service` to that value, the same way `init().version` already defaults to the build's version. An explicit `init()` value wins, and a mismatch logs a warning. `service` becomes optional in the init configuration type; without one from either place, `init()` logs an error and doesn't start. Build metadata values that aren't non-empty strings are ignored. Environment: Datadog workspace Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Bundles Sizes Evolution
|
🎉 All green!🧪 All tests passed 🎯 Code Coverage (details) 🔗 Commit SHA: 1efc0b7 | Docs | View more details | Give us feedback! |
The build plugin now takes the service from its shared top-level `metadata.service` option instead of `liveDebugger.service`. Update the error message, the type documentation and the README accordingly. Environment: Datadog workspace Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DEBUG-6328: default
init().serviceto the service the Datadog build plugin injects into__DD_LIVE_DEBUGGER_BUILD__, the same wayinit().versionalready defaults to the build's version.The build plugin uploads each build's function list (the symbol table) to Live Debugger under its shared
metadata.serviceoption. Live Debugger finds it by the service this SDK reports, so the two must match. Taking it from the build removes the risk of configuring it differently in two places. Build-plugins side: DataDog/build-plugins#593.servicebecomes optional inDebuggerInitConfiguration, andDebuggerBuildMetadatagainsservice. Both only loosen the types.versiontoo, likedebugIdalready was.Evidence
init()withoutservicestarted anyway and polled the Delivery API without a service.After:
main.spec.ts, 21/21 (up from 10):init()service wins and warns on a mismatch;'',123) is ignored;init()logs an error and nothing starts.yarn eslint packages/browser-debugger,yarn prettier --check packages/browser-debuggerandyarn typecheckare clean.Merge Danger
Door: two-way
Blast Radius: Browser Debugger SDK
init()service, and runs on a build without the build plugin's service, now gets an error and no init instead of a broken one.serviceininit()keeps working as before.🤖 Generated with Claude Code