Skip to content

Make sure pointers and alignments are 64-bits #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
illwieckz wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Make sure pointers and alignments are 64-bits #49

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7815be5
src/common/memory_allocator: preserve 64-bit alignment masks
illwieckz Oct 15, 2026
00b36c9
src/processor/minidump_processor: preserve 64-bit exception addresses
illwieckz Oct 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/common/memory_allocator.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,8 @@ class PageAllocator {
template <typename T>
static T AlignUp(T offset, size_t alignment) {
assert(alignment > 0 && ((alignment - 1) & alignment) == 0);
return (offset + (alignment - 1)) & ~(alignment - 1);
const T mask = static_cast<T>(alignment - 1);

@slipher slipher Oct 16, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change doesn't change the semantics of the code at all. It just factors out a common subexpression without changing its type.

If there were really an issue due to passing in an alignment larger than 2^32, you'd have to change the type of the function argument. But a 32-bit process can't allocate more than 2^32 so that doesn't makes sense and can't happen.

return (offset + mask) & ~mask;
}

// Allocates an array with requested amount of `bytes` and at a location with
Expand Down
2 changes: 1 addition & 1 deletion src/processor/minidump_processor.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -436,7 +436,7 @@ static const MDRawSystemInfo* GetSystemInfo(Minidump* dump,
}

static uint64_t GetAddressForArchitecture(const MDCPUArchitecture architecture,
size_t raw_address)
uint64_t raw_address)
{
switch (architecture) {
case MD_CPU_ARCHITECTURE_X86:
Expand Down