Skip to content

Demangling/symbol handling robustness #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
illwieckz wants to merge 2 commits into
base: master
Choose a base branch
from
+11 −1
Open

Demangling/symbol handling robustness #45

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
da67130
src/common/stabs_to_module_unittest: use POSIX regex on POSIX systems…
illwieckz Oct 12, 2026
37abbfa
src/common/stabs_to_module: check mangled names before demangling STA…
illwieckz Oct 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/common/stabs_to_module.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,12 +44,16 @@
#include <utility>

#include "common/stabs_to_module.h"
#include "common/language.h"

namespace google_breakpad {

// Demangle using abi call.
// Older GCC may not support it.
static std::string Demangle(const std::string& mangled) {
if (!Language::IsMangledName(mangled))
return mangled;

int status = 0;
char *demangled = abi::__cxa_demangle(
mangled.c_str(), nullptr, nullptr, &status);
Expand Down
8 changes: 7 additions & 1 deletion src/common/stabs_to_module_unittest.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,9 +214,15 @@ TEST(FunctionNames, Mangled) {
Module::Function *function = functions[0];
// This is GCC-specific, but we shouldn't be seeing STABS data anywhere
// but Linux.
#ifdef _WIN32
#define WHITESPACE_REGEX "\\s"
#else
#define WHITESPACE_REGEX "[[:space:]]"
#endif
EXPECT_THAT(function->name.str(), ::testing::ContainsRegex(
"std::vector<unsigned long long, std::allocator<unsigned long long>\\s?>::"
"std::vector<unsigned long long, std::allocator<unsigned long long>" WHITESPACE_REGEX "?>::"
"push_back\\(unsigned long long const&\\)"));
#undef WHITESPACE_REGEX
EXPECT_EQ(0xf2cfda63cef7f46dLL, function->address);
EXPECT_LT(0U, function->ranges[0].size); // should have used dummy size
EXPECT_EQ(0U, function->parameter_size);
Expand Down