Repository navigation
Conversation
Member
|
How can 6910c9d9165801d8827d628cb72eb7ea9dd538c5 be too old when that's the one upstream uses? |
Member
|
Oh now I see
But it turns out not to be old: it is still in sync with upstream's |
Member
Author
|
Right, after some research, the commit reference was |
Member
Author
|
Since https://github.com/DaemonEngine/googletest is also on |
Member
Author
I meant the url (my phrase was ambiguous). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Running
./fetch-externals(required formake check) will now clone a newer version ofgoogletestthat is now required. Breakpad requires C++20 and I have faced some old references ofgoogletestnot supporting it.I haven't checked if that exact old reference was broken, but I've checked that the new reference is working.
We may use https://github.com/DaemonEngine/googletest if preferred.
Picked from: