Skip to content

deps: update googletest reference - #39

Open
illwieckz wants to merge 1 commit into
masterfrom
illwieckz/deps
Open

illwieckz wants to merge 1 commit into
masterfrom
illwieckz/deps

Conversation

@illwieckz

@illwieckz illwieckz commented Oct 11, 2026 •

Copy link
Copy Markdown
Member

Running ./fetch-externals (required for make check) will now clone a newer version of googletest that is now required. Breakpad requires C++20 and I have faced some old references of googletest not supporting it.

I haven't checked if that exact old reference was broken, but I've checked that the new reference is working.

We may use https://github.com/DaemonEngine/googletest if preferred.

Picked from:

@slipher

slipher commented Oct 12, 2026

Copy link
Copy Markdown
Member

How can 6910c9d9165801d8827d628cb72eb7ea9dd538c5 be too old when that's the one upstream uses?

@slipher

slipher commented Oct 12, 2026 •

Copy link
Copy Markdown
Member

Oh now I see

I haven't checked if that exact old reference was broken

But it turns out not to be old: it is still in sync with upstream's .gitmodules (they switched to submodules less than a year ago).

@illwieckz

illwieckz commented Oct 12, 2026 •

Copy link
Copy Markdown
Member Author

Right, after some research, the commit reference was 5ec7f0c4a113e2f18ac2c6cc7df51ad6afc24081 after the main merge in our tree. Maybe a merge mismatch. That 5ec7f0 is not suitable for sure.

@illwieckz

Copy link
Copy Markdown
Member Author

Since https://github.com/DaemonEngine/googletest is also on 6910c9d, we mays also use that as upstream.

@illwieckz

Copy link
Copy Markdown
Member Author

Since https://github.com/DaemonEngine/googletest is also on 6910c9d, we mays also use that as upstream.

I meant the url (my phrase was ambiguous).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants