Add persistent device-geometry visibility control - #29
Merged
Merged
Conversation
This was referenced Sep 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #23.
Add a keyboard-operable Show device geometry checkbox. It toggles the renderer's existing device group, including all plane/sphere/box/cylinder meshes and associated outlines. Store the preference for the current dataset so frame rebuilds, live reset, and missing/returning geometry retain the user's choice. Opening another dataset restores the enabled default.
Cells, picking, selection highlights, signal slices, the reference grid, camera pose, and the existing Fit bounds policy remain independent. The setting changes presentation only; no simulation constraints, checkpoints, or obstacle masks are changed.
Validation: 37 Vitest tests; TypeScript/production build, formatting, and whitespace checks pass. Real Chromium 153 checks actual keyboard toggling, all four constraint types, hidden/shown screenshots, cell picking and inspection, camera/Fit invariance, frame/reset/reverse-time retention, missing geometry, and new-dataset defaults. Reproducible script:
viewer/browser/device-visibility.mjs.Originally stacked on #27 (
marpaia/20) for its dataset lifecycle. The actual #16 replay UI passed the combined acceptance check.Independent review is complete against the original acceptance criteria and intended review base. The review report records per-criterion evidence, both corrected campaign findings, exact tested heads, landing order and platform limits.
Merged into master in the approved campaign order: #26, #27, #28, #31, #34, #36, #29, #30, #33, #35, #37, #32. The final tree preserves the reviewed implementation and integration regressions. Prerequisites were integrated with merge commits, and the frozen review bases were retained.
Landing validation: 534 Python tests passed (57 environment-dependent skips), 115 viewer tests passed, Ruff lint, strict type checks, viewer build/format checks, and actual Chromium feature/integration checks passed. Pyright retains the existing native-extension source warning. A Windows-only documentation link-test encoding failure was reproduced and fixed with an explicit UTF-8 read; the corrected final PR heads passed Windows CLI/shutdown checks and CUDA compilation. NVIDIA runtime execution remains unverified.