Repository navigation
fix(waterdata): accept the latest-continuous method_category queryable - #459
Merged
thodson-usgs merged 1 commit intoOct 29, 2026
Conversation
thodson-usgs
force-pushed
the
fix/latest-continuous-method-category
branch
2 times, most recently
from
October 29, 2026 14:33
720b9ac to
2562b51
Compare
USGS added method_category to the latest-continuous collection between the 10/28 and 10/29 nightly live runs, on both v0 and v1, which turned three live monitors red. get_continuous has taken it since DOI-USGS#423; get_latest_continuous now takes it as a keyword-only parameter and lists it as a returned column. Regenerate the queryables snapshot, and refresh the latest-continuous fixture so it carries one categorized series and one null. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
thodson-usgs
force-pushed
the
fix/latest-continuous-method-category
branch
from
October 29, 2026 14:41
2562b51 to
87442c0
Compare
thodson-usgs
marked this pull request as ready for review
October 29, 2026 14:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
USGS added
method_categoryto thelatest-continuouscollection between the 10/28 and 10/29 nightly runs, on both v0 and v1. Three live monitors failed on it (upstream run, fork run).get_continuoushas taken the same column since #423; this does the same forget_latest_continuous.def get_latest_continuous( ... max_rows: int | None = None, + *, + method_category: str | Iterable[str] | None = None, **queryables: Any, )method_categoryadded to thepropertieslist and documented with the same text asget_continuous.tests/data/waterdata_queryables.json: regenerated from v1; the only change is the one line forlatest-continuous.tests/data/waterdata_ogc_fixtures.json: thelatest-continuousfixture is re-captured for the same two time series. It now carriesmethod_category:UNKWNfor 00065 and null for 00060.NEWS.md: entry dated 10/29/2026.Evidence
pytest -m liveon main:pytest -m live tests/waterdata_properties_test.py tests/waterdata_queryables_test.py: 29 passed. Offline suite: 1758 passed, coverage 99.08% (gate 98.9).latest-continuous(v0 and v1 identical): the field is in/queryablesand/schema. Filtering onUNKWN,STNRDorLMTUSreturns rows;EXPERand an invalid code return 0 rows; an unknown parameter still returns 400.Merge Danger
Door: two-way
Blast Radius: none
The parameter is keyword-only, so every existing call sends the same request as before. Before this change,
method_categorycould already be passed through**queryables.🤖 Generated with Claude Code