gui/create-item: add 0-5 hotkeys to quality prompt - #1634
Closed
Alistair-Afton wants to merge 1 commit into
Closed
Alistair-Afton wants to merge 1 commit into
Alistair-Afton wants to merge 1 commit into
Conversation
Author
|
Duplicate of #1616, which already implements this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes DFHack/dfhack#5770
The quality prompt in
gui/create-itemnow assigns digit hotkeys 0-5 to the six quality options, matching the internalitem_qualityvalues.widgets.Listalready supports per-choice keys, so this is just annotating the choice table.Testing
Verified the
widgets.Listchoice-key path in game: feedingSTRING_A053selects index 6 (Masterwork),STRING_A048selects index 1 (None).