Skip to content

notes test: pause the game while the overlay is installed #1632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Alistair-Afton wants to merge 2 commits into
base: master
Choose a base branch
from
Open

notes test: pause the game while the overlay is installed #1632

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0e3d837
notes test: pause the game while the overlay is installed
Alistair-Afton Sep 17, 2026
cfdefba
notes test: use dfhack.world pause API instead of raw pause_state
Alistair-Afton Sep 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions test/overlay/notes.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,16 @@ config = {

local map_points_backup = nil
local was_overlay_enabled = overlay.isEnabled()
local was_paused = nil

local function install_notes_overlay(options)
options = options or {}

-- the overlay does not draw note pins in text mode unless the game is
-- paused, so don't depend on whatever pause state the test harness left
was_paused = dfhack.world.ReadPauseState()
dfhack.world.SetPauseState(true)

map_points_backup = utils.clone(map_points)
map_points:resize(0)

Expand Down Expand Up @@ -51,6 +57,11 @@ local function cleanup(notes_overlay)
end
map_points_backup = nil

if was_paused ~= nil then
dfhack.world.SetPauseState(was_paused)
was_paused = nil
end

reload_notes()

overlay.setEnabled(was_overlay_enabled)
Expand Down
Loading