quickfort: remove dead code for retired query/config modes - #1626
Open
Alistair-Afton wants to merge 1 commit into
Open
Alistair-Afton wants to merge 1 commit into
Alistair-Afton wants to merge 1 commit into
Conversation
The query and config blueprint modes were retired in the v50 quickfort rewrite: parse_modeline() maps their modelines to "ignore", so the query.lua, config.lua, aliases.lua, and keycodes.lua modules have been unreachable ever since. aliases.lua still tried to load data/quickfort/aliases-common.txt, a file that no longer exists in installations (dfhack#5755). Also update the dormant unit tests that still exercised the removed modules and settings.
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes DFHack/dfhack#5755
Summary
parse_modeline()maps their modelines toignore, soquery.lua,config.lua,aliases.lua, andkeycodes.luahave been unreachable ever since.aliases.luastill referenceddata/quickfort/aliases-common.txt, which was deleted during the data directory restructure and is not part of the install set. This removes the dangling reference along with the rest of the dead code.test/quickfortunit tests that still exercised the removed modules and settings (query_unsafe,read_settings, etc. no longer exist), and fixedlist_integrationexpectations for the retired modelines.#aliasessections andctx.aliasesare unaffected — that machinery lives inparse.lua/list.luaand is still used by dig/build/place/zone/burrow/meta/notes.Testing
quickfortand ranquickfort listandapply_blueprintin-game to verify nothing in the live path touches the removed modules.