Skip to content

quickfort: remove dead code for retired query/config modes - #1626

Open
Alistair-Afton wants to merge 1 commit into
DFHack:masterfrom
Alistair-Afton:fix-quickfort-dead-query-code
Open

Alistair-Afton wants to merge 1 commit into
DFHack:masterfrom
Alistair-Afton:fix-quickfort-dead-query-code

Conversation

@Alistair-Afton

Copy link
Copy Markdown

Fixes DFHack/dfhack#5755

Summary

  • The query and config blueprint modes were retired in the v50 quickfort rewrite: parse_modeline() maps their modelines to ignore, so query.lua, config.lua, aliases.lua, and keycodes.lua have been unreachable ever since.
  • aliases.lua still referenced data/quickfort/aliases-common.txt, which was deleted during the data directory restructure and is not part of the install set. This removes the dangling reference along with the rest of the dead code.
  • Also updated the dormant test/quickfort unit tests that still exercised the removed modules and settings (query_unsafe, read_settings, etc. no longer exist), and fixed list_integration expectations for the retired modelines.
  • Per-blueprint #aliases sections and ctx.aliases are unaffected — that machinery lives in parse.lua/list.lua and is still used by dig/build/place/zone/burrow/meta/notes.

Testing

  • Loaded quickfort and ran quickfort list and apply_blueprint in-game to verify nothing in the live path touches the removed modules.
  • If query mode ever needs to come back, the removed modules are recoverable from git history.

The query and config blueprint modes were retired in the v50 quickfort
rewrite: parse_modeline() maps their modelines to "ignore", so the
query.lua, config.lua, aliases.lua, and keycodes.lua modules have been
unreachable ever since. aliases.lua still tried to load
data/quickfort/aliases-common.txt, a file that no longer exists in
installations (dfhack#5755).

Also update the dormant unit tests that still exercised the removed
modules and settings.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

References to non-existing files

1 participant