hide-tutorials: suppress the adventure mode start tutorial - #1622
Open
Alistair-Afton wants to merge 1 commit into
Open
Alistair-Afton wants to merge 1 commit into
Alistair-Afton wants to merge 1 commit into
Conversation
The first adventure tutorial (enabled by the tutorial checkbox at adventurer creation) was not covered: it is not a POPUP_ context, so hide_all_popups never touched it, and the dialog requires dismissing through the ? button. Now the setup screen's want_tutorial checkbox defaults to off (the player can still opt in), and a pending tutorial is cancelled on map load / dungeonmode entry by clearing plotinfo.flags.need_to_do_tutorial and closing any open ADVENTURE_START_* help popup. Fixes DFHack/dfhack#5779
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
viewscreen_setupadventurestopens (want_tutorial = false); the player can still check it if they want the tutorialplotinfo.flags.need_to_do_tutorialand close any openADVENTURE_START_*help popup on map load and when the adventure screen appears, cancelling a tutorial that is already pendinghide_all_popupsonly coverADVENTURE_POPUP_*contexts, so the start tutorial sequence was entirely unhandledFixes DFHack/dfhack#5779
Testing
skip_adventure_tutorialcloses a forcedADVENTURE_START_MESSAGEpopup and clears the pending flagneed_to_do_tutorialadvances the help context toADVENTURE_START_MESSAGE, confirming the flag drives the tutorial sequencewant_tutorialwrite is a single field assignment verified against the current structures