test: add coverage for tailor, eventful, hotkeys, dig, stockpiles - #5931
Open
Alistair-Afton wants to merge 1 commit into
Open
Alistair-Afton wants to merge 1 commit into
Alistair-Afton wants to merge 1 commit into
Conversation
Alistair-Afton
force-pushed
the
test-plugin-coverage-4
branch
2 times, most recently
from
September 17, 2026 15:12
494f2eb to
c94454c
Compare
Also fixes eventful's world-unload cleanup unhooking the wrong events: it cleared onReactionComplete (never bound) instead of onReactionCompleting (bound by registerReaction), and never cleared onWorkshopFillSidebarMenu (bound by registerSidebar). Registered hooks leaked into subsequently loaded worlds and could fire against stale state.
Alistair-Afton
force-pushed
the
test-plugin-coverage-4
branch
from
September 18, 2026 06:47
c94454c to
c408688
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tailor(confiscate/dye toggles, material ordering),eventful(reaction/sidebar registration and dispatch),hotkeys(Armok filtering, binding discovery, internal menu filtering),dig(digcircle designations, cursor handling), andstockpiles(status, filename validation, export/import round trip)eventfulworld-unload cleanup: it unhookedonReactionComplete(never bound by the module) instead ofonReactionCompleting(bound byregisterReaction), and never unhookedonWorkshopFillSidebarMenu(bound byregisterSidebar). Registered callbacks leaked across world loads and could fire against stale state — the newworld_unload_clears_registrationtest catches thisdigcircle's "do it again" static argument memory by always passingset/unsetexplicitlyTest plan
ci/lint.pyclean on all touched files