Skip to content

test: add coverage for plant, prospector, autonestbox, tiletypes, timestream - #5930

Open
Alistair-Afton wants to merge 1 commit into
DFHack:developfrom
Alistair-Afton:test-plugin-coverage-3
Open

Alistair-Afton wants to merge 1 commit into
DFHack:developfrom
Alistair-Afton:test-plugin-coverage-3

Conversation

@Alistair-Afton

Copy link
Copy Markdown
Contributor

Summary

  • add regression tests for plant, prospector, autonestbox, tiletypes, and timestream
  • timestream: pass the validated numeric value to the fps setter so set fps with unusual numeric strings (e.g. 60.9) can't be silently misapplied

Test plan

  • all 41 new tests pass in-game
  • full in-game main-repo test suite passes (346/346 tests)

…estream

Also fixes timestream's `set fps` passing the raw argument string to the
C++ setter instead of the validated number, which could misapply values
that only parse as floats (e.g. "60.9").
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant