Skip to content

buildingplan: fix roller chain estimate #5919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ab9rf merged 3 commits into from
Sep 17, 2026
+3 −1
Merged

buildingplan: fix roller chain estimate #5919

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6075676
buildingplan: fix roller chain estimate
Alistair-Afton Sep 16, 2026
17a4dc5
reorder changelog.txt
ab9rf Sep 17, 2026
d0b37fb
Merge branch 'develop' into fix-roller-chain-estimate
ab9rf Sep 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions docs/changelog.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,7 @@ Template for new versions:
- `3dveins`: fix failure on embarks that cross midmap tiles
- `aquifer`: make ``--skip-top`` and top-relative ``--levels`` take effect for the ``drain``, ``convert``, and ``add`` actions instead of being silently ignored
- `autodump`: ``destroy`` no longer leaves the contents of destroyed containers in limbo or crashes when destroying unit-held items
- `buildingplan`: fix roller material estimate asking for one chain per tile instead of one chain total

@ab9rf ab9rf Sep 17, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nit: I prefer that changelog entries be in alphabetical order by affected tool. Will fix this one myself this time, and need to remind myself to update our contribution standards

- `buildingplan`: fix "Unlink all" only unlinking some mechanisms (or crashing) when freeing mechanisms from the building
- `timestream`: deal properly with units who have breathing difficulties
- `stocks`: overlay now resets scroll position when collapsing categories so the item list is no longer left blank and unscrollable
Expand Down
3 changes: 2 additions & 1 deletion plugins/lua/buildingplan/planneroverlay.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,7 +208,8 @@ local function get_quantity(filter, hollow, bounds)
end
return quantity * count
end
return quantity * get_selected_volume(bounds)
-- job item quantities are totals for the whole building, not per-tile
return quantity
end

local function cur_building_has_no_area()
Expand Down
Loading