ci/test.lua: reinstate loading of a specified save dir - #5907
Draft
Alistair-Afton wants to merge 1 commit into
Draft
Alistair-Afton wants to merge 1 commit into
Alistair-Afton wants to merge 1 commit into
Conversation
load-save works on the current title screen again, so ensure_fortress can honor the documented -s/--save_dir option instead of always loading the first save in the list. The load-first-save helpers it replaced are no longer needed.
Alistair-Afton
force-pushed
the
test-load-save-dir
branch
from
September 15, 2026 15:43
926da7c to
ec4e728
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reinstates the
load-savecall inensure_fortressso the documented-s/--save_dirtest option actually selects which save to load, instead of always loading the first save in the list. Theload_first_save/click_top_title_buttonhelpers it replaced are no longer needed.Depends on DFHack/scripts#1619 (the
load-savefix) merging and the scripts submodule pin updating. Until then the firstrun_script('load-save', ...)call hits theunavailablewarning and qerrors, which would abort fortress-mode tests.Testing
dfhack.run_script('load-save', 'region1')from the title screen loads the region1 fortensure_fortressitself once the scripts pin includes the fix