workshop_type: update name attrs to current in-game names - #907
Open
Alistair-Afton wants to merge 1 commit into
Open
Alistair-Afton wants to merge 1 commit into
Alistair-Afton wants to merge 1 commit into
Conversation
The enum item attrs still had a pre-v50 name for the mason's workshop and no name for the renamed kennel. Use the names the game actually displays: Stoneworker's Workshop (was Mason's Workshop) and Vermin Catcher's Shop for Kennels.
Alistair-Afton
force-pushed
the
fix-stale-workshop-names
branch
from
September 16, 2026 02:53
098644d to
b6c77ff
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
nameitem attrs onworkshop_typestill had the pre-v50 display name for the mason's workshop, and the renamed kennel had no name attr at allMasons: "Mason's Workshop" -> "Stoneworker's Workshop"Kennels: added "Vermin Catcher's Shop"buildingst::getNameon abuilding_workshopstof every type on 53.16 (withraceset, since the craftsdwarf name is race-dependent); these were the only mismatchesTesting
getNameoutput vs attrs for all 25 workshop types