Repository navigation
Fix Insert capacity calculation for existing large buffers - #150
Open
dajiaohuang wants to merge 1 commit into
Open
dajiaohuang wants to merge 1 commit into
dajiaohuang wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
A supported
Utf16ValueStringBuilder.Insertcan throwArgumentException: Destination is too shortwhen existing text exceeds the default buffer size. For example, append 33,000acharacters, then callInsert(1, "b"). The new buffer is sized using the insertion index rather than the existing text length, so it cannot hold the retained suffix.Related: #125 (closed by stale automation).
Change
Size the new buffer from the current length plus the inserted text length. Add BCL-comparison regressions for pooled/thread-static builders and insertion at the start/middle. Update the Unity source through the existing netstandard2.1 post-build copy target.
Validation
DOTNET_ROLL_FORWARD=Majorbecause .NET 7 runtime is unavailable locally.