Safely handle and preserve tokio spawn_blocking errors in web endpoints - #425
Conversation
…t dirs - Replaced `.unwrap_or_else` in `src/interface/web.rs` task handling with proper `map_err().and_then()` chains to properly preserve and propagate `.await` failures on web endpoints as per REQ-SEC. - Cleaned up unneeded `.mutants.out` logic and correctly patched `tests/contract_port_matrix.rs` to allow safe nested markdown creation across systems.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
This commit addresses the issue of propagating thread/task join errors safely in the Axum web routes when spinning up
tokio::task::spawn_blocking. It drops the unneededunwrap_or_elsefallbacks that ignored runtime panics and standardizes on.map_err().and_then()context propagations. It also fixes a bug incontract_port_matrix.rsby ensuring thatPORT-MATRIX.mdis generated into an existing directory. Tested via./verify.sh.PR created automatically by Jules for task 8288305977386607064 started by @Cylae