Repository navigation
Correct ProSMART Rama-Z guidance and add before/after X-ray assessment - #916
Conversation
|
Final acceptance at The required locked Python 3.12.11 benchmark gate passed in 130.76 seconds on a clean, unchanged head. Linux and macOS CI both passed: https://github.com/CultureBotAI/protstruct_review/actions/runs/41915447226. The final #949 matrix and #934 reflection-audit prose repairs are verified. All 33 findings are recorded: 30 fixed in this PR (#917–922 and #926–949), and #923/#924/#925 rejected and closed not planned. The fixed issues remain open until merge; the PR description has the 31 closing references including parent #911. Existing follow-ups #760/#765/#790/#799/#872/#873/#876 remain open and outside this PR. Review scope is explicit: newly inspected source is distinguished from reviews carried forward on unchanged blobs. PRIMARY checked the final review's actual read/command receipts. Task009's false source/execution claims and the failed scratch suite are excluded from acceptance evidence. Current matrix applicability was checked directly; committed wrong-task matrix-mutation coverage remains a documented limitation. The secondary is idle. PRIMARY remains on main, the original untracked handoff is uncommitted, and no orchestration files were committed. |
|
Fresh-context adversarial review completed at
No new follow-up was triaged from this review; no P0/P1 or user-scientific-judgment blocker was found. Existing follow-ups remain separate. Fixes, PRIMARY QC, a fresh fix-diff review and final-head Linux/macOS SUCCESS plus CLEAN are required before the specifically authorized squash merge. No merge has occurred. |
|
Fix commit Two in-scope P3 prose residuals are recorded on existing issues: #950 option names and #926 audit chronology/status. No new finding issue was needed. A separate fresh-context read-only review of the five-file fix diff and PRIMARY's locked QC are running; final push, CI and merge await acceptance. |
|
Final acceptance at Both |
|
PR #916 is squash-merged as Both final-head validate checks passed in run41990664847, and merge status was CLEAN immediately before the head-pinned squash. PRIMARY also ran the locked Python 3.12 gate on main after fast-forwarding: exit 0 in 129.98 seconds, stable clean tracked state. Fresh review filed and fixed #950/#951, with deduplicated residuals addressed on #934/#926. All 33 intended issues are verified CLOSED/COMPLETED: #911, #917–#922 and #926–#951. GitHub completed every closure automatically; no manual closure was needed. Rejected #923–#925 remain CLOSED/NOT_PLANNED. Follow-ups #760, #765, #790, #799, #872, #873 and #876 remain OPEN; the complete remaining queue is seven issues and zero PRs. The clean, fully pushed |
ProSMART was recommended for a Ramachandran-distribution Z-score that its documented comparative scores do not establish. This PR adds dated recommendation and assumption successors, corrects its score definitions and comparison modes, and preserves predecessor records and frozen EVAL/QDS evidence.
The new X-ray before/after workflow and 1SAR case study separate implementation agreement, final-model evidence, and change from the actual input. Fixed source bundles are admitted by verified bytes before conclusions are drawn. Coordinate, inventory and reflection-retention arithmetic is recomputed; historical oracle observations retain their provenance limits. The T01–T17 tools guide distinguishes documented capabilities, local implementations, retained evidence and applicable interpretation, including the limits of free superposition for placement validation.
Fresh review and fixes:
6bd461b5e9f005646431cd373e97ffad3aa5d80dtoe8769e6366736196a42909445f0beeffae6ef598. It produced new issues P2: distinguish Gemmi superposition from experimental-frame placement validation #950/P2: bind fixed control conclusions to their admitted source bytes #951 and a duplicate P2: 1SAR case study invents Servalcat free-flag and R-factor mechanisms #934 denominator finding; all were triaged in scope and fixed.2f52b15corrects placement guidance, binds the three retained control sources, adds regressions, and qualifies the historical reflection count. Fresh fix-diff review and PRIMARY verification caught two prose residuals, recorded under P2: distinguish Gemmi superposition from experimental-frame placement validation #950/P2: correct unsupported task 001 review evidence before PR acceptance #926 and corrected ind039ebd.Validation at final head
d039ebd8786e7b90d1e76197a418ce352fec6548:uv run --locked --extra benchmark -- bash scripts/validate.shon Python 3.12.11: exit 0 in 124.87 seconds, with a clean, unchanged head. The preceding code-fix head also passed PRIMARY's full gate and all 26 focused tests passed in independent review.db100e926bfcf6331c303087846c4d51117a4411c6afdf58877aada5dbf14245).Closes #911, closes #917, closes #918, closes #919, closes #920, closes #921, closes #922, closes #926, closes #927, closes #928, closes #929, closes #930, closes #931, closes #932, closes #933, closes #934, closes #935, closes #936, closes #937, closes #938, closes #939, closes #940, closes #941, closes #942, closes #943, closes #944, closes #945, closes #946, closes #947, closes #948, closes #949, closes #950, closes #951.
Existing follow-ups #760, #765, #790, #799, #872, #873 and #876 remain open and outside this PR. No new follow-up was added by the fresh review.
The dated audit checkpoints preserve review history; the final review and CI state are recorded here.