Skip to content

Renamed and moved MeetTime' and Time data types to Models.Meeting and Models.Time - #1810

Merged
david-yz-liu merged 5 commits into
Courseography:masterfrom
danielrafailov:refactor-meeting-time-data
Oct 2, 2026
Merged

david-yz-liu merged 5 commits into
Courseography:masterfrom
danielrafailov:refactor-meeting-time-data

Conversation

@danielrafailov

@danielrafailov danielrafailov commented Sep 29, 2026 •

Copy link
Copy Markdown
Contributor

Proposed Changes

  • Refactored Database.Tables.MeetTime' into Models.Meeting and renamed it to MeetingData
  • Refactored Database.Tables.Time into Models.Time and renamed it to TimeData

Type of Change

Type Applies?
🚨 Breaking change (fix or feature that would cause existing functionality to change)
✨ New feature (non-breaking change that adds functionality)
🐛 Bug fix (non-breaking change that fixes an issue)
🎨 User interface change (change to user interface; provide screenshots)
♻️ Refactoring (internal change to codebase, without changing functionality) X
🚦 Test update (change that only adds or modifies tests)
📦 Dependency update (change that updates a dependency)
🔧 Internal (change that only affects developers or continuous integration)

Checklist

Before opening your pull request:

  • I have performed a self-review of my changes.
    • Check that all changed files included in this pull request are intentional changes.
    • Check that all changes are relevant to the purpose of this pull request, as described above.
  • I have added tests for my changes, if applicable.
    • This is required for all bug fixes and new features.
  • I have updated the project documentation, if applicable.
    • This is required for new features.
  • If this is my first contribution, I have added myself to the list of contributors.
  • I have updated the project Changelog (this is required for all changes).

After opening your pull request:

  • I have verified that the CI checks have passed.
  • I have reviewed the test coverage changes reported by Coveralls.
  • I have requested a review from a project maintainer.

@danielrafailov danielrafailov changed the title Refactor meeting time data Refactor Database.Tables.MeetTime' and Database.Tables.Time Sep 29, 2026
@danielrafailov danielrafailov changed the title Refactor Database.Tables.MeetTime' and Database.Tables.Time Renamed and moved MeetTime' and Time data types to Models.Meeting and Models.Time Sep 29, 2026
@coveralls

coveralls commented Sep 29, 2026 •

Copy link
Copy Markdown

Coverage Report for CI Build 36921481833

Warning

Build has drifted: This PR's base is out of sync with its target branch, so coverage data may include unrelated changes.
Quick fix: rebase this PR. Learn more →

Coverage decreased (-0.003%) to 60.47%

Details

  • Coverage decreased (-0.003%) from the base build.
  • Patch coverage: 7 uncovered changes across 3 files (2 of 9 lines covered, 22.22%).
  • 54 coverage regressions across 3 files.

Uncovered Changes

File Changed Covered %
app/Models/Time.hs 6 1 16.67%
app/Models/Course.hs 1 0 0.0%
app/Models/Meeting.hs 2 1 50.0%

Coverage Regressions

54 previously-covered lines in 3 files lost coverage.

File Lines Losing Coverage Coverage
js/components/common/export.tsx 40 18.42%
app/Export/GetImages.hs 10 0.0%
app/Models/Meeting.hs 4 20.0%

Coverage Stats

Coverage Status
Relevant Lines: 4319
Covered Lines: 2671
Line Coverage: 61.84%
Relevant Branches: 1001
Covered Branches: 546
Branch Coverage: 54.55%
Branches in Coverage %: Yes
Coverage Strength: 156.77 hits per line

💛 - Coveralls

Comment thread app/Models/Meeting.hs

import GHC.Generics

data MeetingData = MeetingData {meetData :: Meeting, timeData :: [TimeData]}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good, please just add comments explaining the purpose of this data type and of TimeData. (Analogously to CourseData.)

@david-yz-liu david-yz-liu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, @danielrafailov!

@david-yz-liu
david-yz-liu merged commit 7860082 into Courseography:master Oct 2, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants