Repository navigation
Renamed and moved MeetTime' and Time data types to Models.Meeting and Models.Time - #1810
Merged
david-yz-liu merged 5 commits intoOct 2, 2026
Conversation
Coverage Report for CI Build 36921481833Warning Build has drifted: This PR's base is out of sync with its target branch, so coverage data may include unrelated changes. Coverage decreased (-0.003%) to 60.47%Details
Uncovered Changes
Coverage Regressions54 previously-covered lines in 3 files lost coverage.
Coverage Stats💛 - Coveralls |
|
|
||
| import GHC.Generics | ||
|
|
||
| data MeetingData = MeetingData {meetData :: Meeting, timeData :: [TimeData]} |
Contributor
There was a problem hiding this comment.
This is good, please just add comments explaining the purpose of this data type and of TimeData. (Analogously to CourseData.)
david-yz-liu
approved these changes
Oct 2, 2026
david-yz-liu
left a comment
Contributor
There was a problem hiding this comment.
Nice work, @danielrafailov!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Database.Tables.MeetTime'intoModels.Meetingand renamed it toMeetingDataDatabase.Tables.TimeintoModels.Timeand renamed it toTimeDataType of Change
Checklist
Before opening your pull request:
After opening your pull request: