ngmix: default centroid_source to "wcs" everywhere (code now matches runner behaviour) - #895
Open
cailmdaley wants to merge 3 commits into
Open
cailmdaley wants to merge 3 commits into
cailmdaley wants to merge 3 commits into
Conversation
…cit opt-in The ngmix_runner has fallen back to "wcs" when CENTROID_SOURCE is absent from the ini since 31ae736 (2026-06-30), but every Python signature that takes centroid_source (Ngmix.__init__, make_ngmix_observation, do_ngmix_metacal, run_breakdown_grid.py) still defaulted to "hsm", so a collaborator reading the code concluded hsm was the production default. This aligns every signature, script default, and docstring on "wcs" as the default and documents its semantics (catalogue sky position projected through the exposure WCS, the same pixel/offset used to cut the stamp) versus "hsm" (legacy adaptive-moment centroid from stamp pixels). Tests/validation scripts that build stamps without astrometry (no wcs/ra/dec) now pass centroid_source="hsm" explicitly so their behaviour is unchanged. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ngmix runner has defaulted to
centroid_source="wcs"since 31ae736 (2026-06-30) wheneverCENTROID_SOURCEis absent from the ini, but every Python signature still said"hsm"— reading the code, one concludes hsm is the default. This makes"wcs"the default at every level (Ngmix.__init__,make_ngmix_observation,do_ngmix_metacal,run_breakdown_grid.py) and keeps"hsm"as an explicit, documented opt-in; the hsm code path is untouched. Tests and validation scripts that build stamps without astrometry now passcentroid_source="hsm"explicitly, so behaviour is unchanged everywhere.No production behaviour change. Also adds one line to CLAUDE.md noting that the test suite runs inside the
deploy-image.ymlbuild.🤖 Generated with Claude Code