Retry 404 when polling scan status instead of failing the wait - #176
Draft
Ibrahimrahhal wants to merge 1 commit into
Draft
Ibrahimrahhal wants to merge 1 commit into
Ibrahimrahhal wants to merge 1 commit into
Conversation
A just-created scan can 404 on the first status reads before every replica sees the row. That used to exit 1 immediately, so CI treated a running scan as failed. Ride out 404/5xx for a short grace period, fail-fast on auth, and word a missed status check as a status-check failure rather than a scan failure. Co-authored-by: ibrahim <ibrahim@corgea.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
If
corgea scan(orcorgea wait) successfully starts/finds a scan and then a status poll returns 404, the CLI used to exit 1 immediately. That looks like the scan failed in CI (Scan exited with code: 1) even though the scan is often still running in the cloud — typically replica lag right after upload.This change:
A scan that actually ends in
incomplete/failedstill printsScan <id> did not complete.withfailed_reason/ scanner errors and exits 1.Test plan
corgea wait: processing → 404 → complete succeedsStopped waiting/not found), notdid not complete./harness checkon this branch (842 tests passed)