Repository navigation
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
BigDataDZ
left a comment
There was a problem hiding this comment.
Independent verification on native Windows 10 (zh-CN, cp936), with the same one-line change applied (timeout: 15000 -> 60000 in captureRuntime) - byte-identical to this PR's patch, which I had also staged locally while preparing the #176 follow-up; I am not opening a competing PR.
npx tsx --import ./tests/setup.ts --test tests/telemetry.test.ts: 3/3 pass. The attribution probe took 55.7 s under a cold, post-checkout run - well past the old 15 s timeout and close enough to 60 s that the new budget is needed headroom, not generosity. Opt-out probe 33.4 s, zero-sample probe 7.8 s.
The change touches only the child-process timeout and leaves every assertion intact, so warm-cache ubuntu CI is unaffected as described. Good to merge from the issue reporter's side.
Summary
Issue #176 includes clean-clone Windows reproductions, with one probe taking 32.9 seconds under cold transpilation and parallel test load. The 15-second timeout terminates it before it can emit output.
Verification:
git diff --checkpassed.Closes #176