Feat : truncate overflowing content of TextEntry and TextUpdate, append ellipsis - #3928
Open
gabriel-desmarchelier wants to merge 3 commits into
Open
gabriel-desmarchelier wants to merge 3 commits into
gabriel-desmarchelier wants to merge 3 commits into
Conversation
…tween value_text and truncated_value_text
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


If the content of a TextEntry or a TextUpdate is wider than the width of the field, the displayed value is truncated without any warning. Our operators are quite frequently misled by this lack of accuracy.
What it currently looks like with various display formats :
In this PR, I created a
truncateTextmethod that truncates the actual value and appends (or prepends, depending on horizontal alignment) an ellipsis. The result is stored in thetruncated_value_textstring.I use the
focusPropertylistener to switch the displayed text between the full and the truncated ones : whenever the widget gets the focus, one must be able to read and edit the actual value.The behavior of the multi-line TextEntry and of the interactive TextUpdate remains unchanged : scrollbars are to be used.
The result :
A bob file to play with the various configurations :
text_field_truncation.tar.gz
This could also be implemented for Spinner widget.
Checklist
Testing:
Documentation: