You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When invisible selected, during edition widget get really invisible resulting to the fact that this is hardly selectionnable (click on it doesn't select it, we have to select it in a selection area) and we tend to forgot that there is an invisible widget and let it forever after that. We can only see it throught the widget tree.
In CSS Boy it was handle better in my opinion.
I propose a little modification to make it only invisible and desaturate (like a ghost). Maybe the effect is not that clear compared to the disable effect that's why it's more transparent and desaturate.
For now it's only a draft, before applying it to all widget (some doesn't extend the function from JFXBaseRepresentation), I wanted to be sure that you are ok with that proposition.
@agaget, could we consider a property/setting for this? Maybe an opacity property that defaults to zero to make this "backwards compatible"?
Yes i can consider that :)
I understand the need for backward compatibility but I fear that putting it to 0 by default will just bury the functionnality for the eyes of every user but me ^^.
I don't really see a case where this is not an improvement. At runtime no difference so operation is not disturb and at edition, if it disturbs the developer, she.he could (finally) handle this invisible object the way she.he wants.
But I will do as you please.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When invisible selected, during edition widget get really invisible resulting to the fact that this is hardly selectionnable (click on it doesn't select it, we have to select it in a selection area) and we tend to forgot that there is an invisible widget and let it forever after that. We can only see it throught the widget tree.
In CSS Boy it was handle better in my opinion.
I propose a little modification to make it only invisible and desaturate (like a ghost). Maybe the effect is not that clear compared to the disable effect that's why it's more transparent and desaturate.
For now it's only a draft, before applying it to all widget (some doesn't extend the function from JFXBaseRepresentation), I wanted to be sure that you are ok with that proposition.
What do you think ?