Repository navigation
read_yaml_model: flip usage and pool reactions by the sign of the pool coefficient - #192
Merged
Merged
Conversation
…reaction it turns forward
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The reader turns a
usage_prot_*reaction forward when itsprot_poolcoefficient is positive andprot_pool_exchangewhen it is negative, the GECKO 3 direction, as GECKO'supgradeEcModeldoes. It changed the reactions with a negative lower bound, so a GECKO 4 reaction with a negative lower bound was turned, and the objective coefficient of a turned reaction kept its sign, which reversed the objective. The coefficient now changes sign with the flux. Tests cover a GECKO 3 reaction with an objective coefficient and a forward reaction with a negative lower bound.