Expand the README upgrade note into a guide covering 1.4.1 to 1.6 - #60
Merged
Merged
Conversation
Add sections for the 1.6.0 UTC dates change (affected properties, how to display and compare the values, the DomainRenew fix) and the 1.4.1 TLS default (rebuild to pick it up), alongside the existing 1.5 certificate validation note. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The README's "Upgrading to 1.5" section becomes an Upgrading guide, newest release first:
DomainRenewResponse.ExDateand the four Nominet dates).ToLocalTime()) and comparing (DateTime.UtcNow) the values.DomainRenewnow accepts anexDatedirectly.SslProtocols.Tls.Testing
I ran the 1.6 code sample against 1.6.0 with
TZ=Asia/Tokyo:ExDateis2005-04-03T22:00:00ZwithDateTimeKind.Utc, andToLocalTime()gives2005-04-04T07:00:00+09:00.DomainRenewgiven2026-04-03T22:00:00.0ZsendscurExpDate2026-04-03.The README is packed into the NuGet package, so nuget.org will show this guide from the next release.
🤖 Generated with Claude Code