Document the 1.5 certificate validation change in the README - #56
Merged
Merged
Conversation
Explain that TcpTransport now validates the registry's certificate, and show test environments with self-signed certificates how to pin the certificate's SHA-256 fingerprint through ServerCertificateValidationCallback instead of accepting any. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds an Upgrading to 1.5 section to the README, after the install instructions:
TcpTransportvalidates the registry's server certificate (trusted chain, matching host name, not expired). Earlier versions accepted any certificate.ServerCertificateValidationCallbackthat pins the test certificate's SHA-256 fingerprint instead of returningtrue.opensslcommand.GetCertHashString(HashAlgorithmName)needs .NET Core 3.0+.Testing
I ran the README sample against real servers, using the fingerprint from the
opensslcommand:AuthenticationExceptionThe README is packed into the NuGet package, so nuget.org will show this section from the next release.
🤖 Generated with Claude Code